Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM update detection only works with bors merge commit #109070

Open
nikic opened this issue Mar 13, 2023 · 0 comments
Open

LLVM update detection only works with bors merge commit #109070

nikic opened this issue Mar 13, 2023 · 0 comments
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@nikic
Copy link
Contributor

nikic commented Mar 13, 2023

LLVM update detection in bootstrap currently only works if there is a bors merge commit:

format!("--author={}", config.stage0_metadata.config.git_merge_commit_email).into(),

This means that it's not possible to run docker images with updated LLVM locally. For dist images you can use DEPLOY=1, but for non-dist images we always download CI LLVM. You can't even specify NO_DOWNLOAD_CI_LLVM=1 without patching the Dockerfile or run.sh.

LLVM updates should be detected locally, without a bors merge commit as well.

@nikic nikic added C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 13, 2023
@jyn514 jyn514 added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

2 participants