Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for ConstProp MIR opt #111509

Closed
7 tasks
cjgillot opened this issue May 12, 2023 · 4 comments
Closed
7 tasks

Tracking issue for ConstProp MIR opt #111509

cjgillot opened this issue May 12, 2023 · 4 comments
Assignees
@cjgillot
Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html A-mir-opt Area: MIR optimizations

Comments

@cjgillot
Copy link
Contributor

cjgillot commented May 12, 2023 •
edited
Loading

This issue tracks the regression in ConstProp due to #110719

Regressed optimizations:

  • array indexing;
  • non-scalar constants;
  • assignment of immutable statics;
  • creating rvalues with non-scalar types;
  • integer-to-pointer transmutes;
  • transmutes of scalar enums.

Remaining to do:

  • port const-prop-lint pass to this new implementation.
@cjgillot cjgillot added A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html A-mir-opt Area: MIR optimizations labels May 12, 2023
@cjgillot cjgillot self-assigned this May 12, 2023
@RalfJung
Copy link
Member

RalfJung commented Aug 6, 2023 •
edited
Loading

Once this is all done we can also hopefully remove the ConstPropNonsense error variant from the interpreter, and just replace those cases by assertions.

Also we can re-try #114552.

@cjgillot
Copy link
Contributor Author

cjgillot commented Jan 3, 2024

Closing as we went for another implementation.

@cjgillot cjgillot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2024
@RalfJung
Copy link
Member

RalfJung commented Jan 3, 2024

Can you add some links to what has been done instead?

@cjgillot
Copy link
Contributor Author

cjgillot commented Apr 7, 2024

For bookkeeping, this PR replaced legacy const-prop: #116012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjgillot cjgillot

Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html A-mir-opt Area: MIR optimizations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RalfJung @cjgillot