Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finish and clean up rustc_const_eval's translatable diagnostics. #113117

Open
fee1-dead opened this issue Jun 28, 2023 · 6 comments
Open

finish and clean up rustc_const_eval's translatable diagnostics. #113117

fee1-dead opened this issue Jun 28, 2023 · 6 comments
Labels
A-const-eval Area: Constant evaluation (MIR interpretation) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@fee1-dead
Copy link
Member

fee1-dead commented Jun 28, 2023 •
edited by rustbot
Loading

For some context see this Zulip topic.

cc @RalfJung.

This issue has a few parts:

In #111677 I added a trait called ReportErrorExt which should be replaced by implementing IntoDiagnostic for newtypes. Another thing would be to investigate if the same can be done for MachineStopType which requires being made into a trait object.

this is an example of using fluent's pattern matching for different error messages. These should be eventually replaced by individual messages with their own identifiers instead of pattern matching.

I'll assign this to myself when I get time. Feel free to claim if this is unassigned.
@fee1-dead fee1-dead added C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. A-const-eval Area: Constant evaluation (MIR interpretation) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic labels Jun 28, 2023
@victor-timofei
Copy link

@rustbot claim
I would love to help with this

@fee1-dead
Copy link
Member Author

Hi @victor-timofei, thanks for claiming this! Feel free to open a thread on Zulip and ping me if you get stuck.

@victor-timofei victor-timofei mentioned this issue Jul 3, 2023
Closed
@RalfJung
Copy link
Member

this is an example of using fluent's pattern matching for different error messages. These should be eventually replaced by individual messages with their own identifiers instead of pattern matching.

That link doesn't seem to work here. What are you referring to?

@fee1-dead
Copy link
Member Author

See this

@CastilloDel
Copy link
Contributor

@rustbot claim

@CastilloDel
Copy link
Contributor

@rustbot release-assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-const-eval Area: Constant evaluation (MIR interpretation) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor const_eval diagnostics victor-timofei/rust
4 participants
@RalfJung @victor-timofei @fee1-dead @CastilloDel