Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate different .vscode/setting for different config profile #121173

Open
chenyukang opened this issue Feb 16, 2024 · 0 comments
Open

Generate different .vscode/setting for different config profile #121173

chenyukang opened this issue Feb 16, 2024 · 0 comments
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@chenyukang
Copy link
Member

chenyukang commented Feb 16, 2024 •
edited
Loading

The idea is from rust-lang/rustc-dev-guide#1890

I'm always feeling slow when editing the source code in rustc, today I spent some time to tweak my settings, and I found one reason is rust-analyzer.check.overrideCommand.

On my dev machine x check will spend about 4s, so it's not acceptable if it's executed multiple times.
It will cost about more than 4x time to run x check compared with x check compiler.

Maybe we can generate different .vscode/setting.json for different config profile?
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 16, 2024
@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-feature-request Category: A feature request, i.e: not implemented / a PR. A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chenyukang @jieyouxu @rustbot