Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay def creation for expression-like nodes #129247

Closed
camelid opened this issue Aug 18, 2024 · 2 comments
Closed

Delay def creation for expression-like nodes #129247

camelid opened this issue Aug 18, 2024 · 2 comments
Assignees
@camelid
Labels
A-HIR Area: The high-level intermediate representation (HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Aug 18, 2024

Blocked on #129023.

This would be a longer-term fix for issues like #128901.

cc @BoxyUwU
@camelid camelid added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-HIR Area: The high-level intermediate representation (HIR) labels Aug 18, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 18, 2024
@camelid camelid self-assigned this Aug 18, 2024
@camelid
Copy link
Member Author

camelid commented Aug 18, 2024

I plan to attempt this, using #128844 as a base, once #129244 is merged.

@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 18, 2024
@petrochenkov petrochenkov mentioned this issue Aug 20, 2024
Merged
@camelid
Copy link
Member Author

camelid commented Dec 29, 2024

I believe a different approach was taken in the end.

@camelid camelid closed this as completed Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camelid camelid

Labels
A-HIR Area: The high-level intermediate representation (HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@saethlin @camelid @rustbot