Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLVM 20 changes SPARC alignments, breaking some tests #131074

Closed
durin42 opened this issue Sep 30, 2024 · 2 comments
Closed

LLVM 20 changes SPARC alignments, breaking some tests #131074

durin42 opened this issue Sep 30, 2024 · 2 comments
Labels
A-align Area: alignment control (`repr(align(N))` and so on) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. O-SPARC Target: SPARC processors

Comments

@durin42
Copy link
Contributor

durin42 commented Sep 30, 2024

llvm/llvm-project@dbad963 changes i128s to align at 16 bytes, which causes a few tests to fail:

[codegen] tests/codegen/cast-target-abi.rs#sparc64
[codegen] tests/codegen/repr/transparent-imm-array.rs#sparc
[codegen] tests/codegen/repr/transparent-sparc64.rs
[codegen] tests/codegen/sparc-struct-abi.rs
 ```

I figured I'd report this early in case some SPARC enthusiast wants to try and get to this early.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 30, 2024
@durin42 durin42 added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Sep 30, 2024
@durin42
Copy link
Contributor Author

durin42 commented Sep 30, 2024

More targets showed up after I partially fixed our CI:

    [assembly] tests/assembly/sparc-struct-abi.rs
    [assembly] tests/assembly/stack-protector/stack-protector-target-support.rs#r61
    [assembly] tests/assembly/stack-protector/stack-protector-target-support.rs#r60
    [assembly] tests/assembly/targets/targets-elf.rs#sparc64_unknown_linux_gnu
    [assembly] tests/assembly/targets/targets-elf.rs#sparc_unknown_linux_gnu
    [assembly] tests/assembly/targets/targets-elf.rs#sparc64_unknown_netbsd
    [assembly] tests/assembly/targets/targets-elf.rs#sparc64_unknown_openbsd
    [assembly] tests/assembly/targets/targets-elf.rs#sparc_unknown_none_elf
    [assembly] tests/assembly/targets/targets-elf.rs#sparcv9_sun_solaris

@workingjubilee workingjubilee added A-align Area: alignment control (`repr(align(N))` and so on) O-SPARC Target: SPARC processors labels Nov 1, 2024
@nikic
Copy link
Contributor

nikic commented Nov 7, 2024

Has already been fixed by #132422.

@nikic nikic closed this as completed Nov 7, 2024
@beetrees beetrees mentioned this issue Nov 9, 2024
Merged
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-align Area: alignment control (`repr(align(N))` and so on) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. O-SPARC Target: SPARC processors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@durin42 @nikic @jieyouxu @workingjubilee @rustbot