Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expansion-based box exacerbates pretty-printing to unstableness #26067

Closed
pnkfelix opened this issue Jun 7, 2015 · 2 comments
Closed

expansion-based box exacerbates pretty-printing to unstableness #26067

pnkfelix opened this issue Jun 7, 2015 · 2 comments
Labels
A-pretty Area: Pretty printing (incl. `-Z unpretty`).

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Jun 7, 2015

Spawned off of #23616

The new expansion-based box protocol (#22181) will internally expanded into calls to API methods that are unstable.

This is going to mean that tests that use box that today can be tagged with pretty-expanded FIXME #23616 are going to have to switch to not opting-into the pretty-expanded test, I think due to the same issue as #23616.

(Thinking about the problem now, we could work around this problem by having the pretty-printer inject attributes to turn off the stability checking. This would only work on nightly so it wouldn't resolve #23616 as written, but it would allow us to continue testing pretty-expanded on things that use box, I think...)

@steveklabnik steveklabnik added the A-pretty Area: Pretty printing (incl. `-Z unpretty`). label Jun 8, 2015
@steveklabnik
Copy link
Member

Triage: no changes that I'm aware of.

@Mark-Simulacrum
Copy link
Member

Closing in favor of #23616. I don't see this as being a separate problem, really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pretty Area: Pretty printing (incl. `-Z unpretty`).
Projects
None yet
Development

No branches or pull requests

3 participants