Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0408 needs to be updated to new format #35698

Closed
sophiajt opened this issue Aug 15, 2016 · 4 comments
Closed

E0408 needs to be updated to new format #35698

sophiajt opened this issue Aug 15, 2016 · 4 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@sophiajt
Copy link
Contributor

From: src/test/compile-fail/E0408.rs

E0408 needs a span_label, updating it from:

error[E0408]: variable `y` from pattern #1 is not bound in pattern #2
  --> src/test/compile-fail/E0408.rs:15:19
   |
15 |         Some(y) | None => {} //~ ERROR E0408
   |                   ^^^^

To:

error[E0408]: variable `y` from pattern #1 is not bound in pattern #2
  --> src/test/compile-fail/E0408.rs:15:19
   |
15 |         Some(y) | None => {} //~ ERROR E0408
   |                   ^^^^ pattern doesn't bind `y`
@faebser
Copy link
Contributor

faebser commented Aug 16, 2016

I'm gonna work on this, Part of #35233

@bstrie bstrie added the A-diagnostics Area: Messages for errors, warnings, and lints label Aug 24, 2016
@bstrie
Copy link
Contributor

bstrie commented Sep 25, 2016

I'm going through and freeing up issues for #35233, @faebser are you still interested in finishing this? If not, other people may be interested in basing their work off of @faebser's current PR.

@faebser
Copy link
Contributor

faebser commented Sep 25, 2016

@bstrie: I am still working on the PR over here: #36307

@steveklabnik steveklabnik removed the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 9, 2017
@estebank
Copy link
Contributor

This issue can be closed (changed in #39713):

error[E0408]: variable `y` is not bound in all patterns
 --> <anon>:5:19
  |
5 |         Some(y) | None => {}
  |              -    ^^^^ pattern doesn't bind `y`
  |              |
  |              variable not in all patterns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Development

No branches or pull requests

5 participants