Rust 1.17 regression - chipmunk-0.0.2, invalid fragment specifier

[brson]

I don't see this already reported but it feels familiar. Looks weird.

https://github.com/TyOverby/chipmunk

brian@ip-10-145-43-250:~/dev/chipmunk⟫ git log -1
commit 8328f04a4cebaaee540aeee7a598a5db675e38b1
Author: Ty Overby <ty@pre-alpha.com>
Date:   Tue Aug 11 19:06:55 2015 -0700

    bump version number

brian@ip-10-145-43-250:/mnt2/dev⟫ rustc +stable -Vv
rustc 1.17.0 (56124baa9 2017-04-24)
binary: rustc
commit-hash: 56124baa9e73f28c0709e59e74783cf234a978cf
commit-date: 2017-04-24
host: x86_64-unknown-linux-gnu
release: 1.17.0
LLVM version: 3.9

brian@ip-10-145-43-250:~/dev/chipmunk⟫ cargo +stable test
   Compiling libc v0.2.22
   Compiling gcc v0.3.45
   Compiling void v1.0.2
   Compiling chipmunk-sys v0.0.4
   Compiling chipmunk v0.0.2 (file:///mnt2/dev/chipmunk)
error: invalid fragment specifier `type`
 --> src/lib.rs:6:21
  |
6 |     ($name:ident <$($typearg:type),*> (&self, $($arg:ident : $typ:ty),*) -> $ret:ty, $(#[$doc:meta])*) => {
  |                     ^^^^^^^^^^^^^
error: invalid fragment specifier `type`
 --> src/lib.rs:6:21
  |
6 |     ($name:ident <$($typearg:type),*> (&self, $($arg:ident : $typ:ty),*) -> $ret:ty, $(#[$doc:meta])*) => {
  |                     ^^^^^^^^^^^^^
  |
  |
  = help: valid fragment specifiers are `ident`, `block`, `stmt`, `expr`, `pat`, `ty`, `path`, `meta`, `tt` and `item`
  = help: valid fragment specifiers are `ident`, `block`, `stmt`, `expr`, `pat`, `ty`, `path`, `meta`, `tt` and `item`


error: invalid fragment specifier `type`
  --> src/lib.rs:34:21
   |
34 |     ($name:ident <$($typearg:type),*> (&mut self, $($arg:ident : $typ:ty),*) -> $ret:ty, $(#[$doc:meta])*) => {
   |                     ^^^^^^^^^^^^^
   |
error: invalid fragment specifier `type`
  --> src/lib.rs:34:21
   |
34 |     ($name:ident <$($typearg:type),*> (&mut self, $($arg:ident : $typ:ty),*) -> $ret:ty, $(#[$doc:meta])*) => {
   |                     ^^^^^^^^^^^^^
   = help: valid fragment specifiers are `ident`, `block`, `stmt`, `expr`, `pat`, `ty`, `path`, `meta`, `tt` and `item`

   |
   = help: valid fragment specifiers are `ident`, `block`, `stmt`, `expr`, `pat`, `ty`, `path`, `meta`, `tt` and `item`

error: aborting due to 2 previous errors

error: aborting due to 2 previous errors

error: Could not compile `chipmunk`.
Build failed, waiting for other jobs to finish...
error: build failed

cc @TyOverby @jseyfried

[TyOverby]

weird, looks like this never should have compiled

[nagisa]

cc @jseyfried

[jseyfried]

This looks like it was caused by #39419, specifically fixing #39404.

[nikomatsakis]

@jseyfried so is this a bug fix? If so, can we close?

[nikomatsakis]

Sure looks like a bug fix to me :)

[nikomatsakis]

triage: P-medium

But probably this can be closed.

[jseyfried]

@nikomatsakis Yeah, this is a bug fix and I think we can close. The alternative would be a warning cycle, which is doable but probably not worth it.