-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source is missing from docs for crates that use a procedural macro #43371
Comments
Minimal reproduction: extern crate heapsize;
#[macro_use] extern crate heapsize_derive;
#[derive(HeapSizeOf)]
pub struct Range; [package]
name = "foo"
version = "0.1.0"
authors = ["Josh Matthews <josh@joshmatthews.net>"]
[dependencies]
heapsize = "0.4"
heapsize_derive = "0.1" If I remove the |
If I use |
|
My money is on #40939. |
cc @jseyfried, @nrc |
I believe the issue is that (since #40939) we no longer accurately track expansion info for names declared in a macro. That means that tools think some names are hand-written, when they are macro generated (this is also causing problems for the RLS). #43179 was meant to fix this, but it did not (at least not for all cases). I haven't looked into the details. |
Not just names. Clippy gets confused by the |
Nominating; needs investigation and a fix. |
This might get fixed by #43230, although perhaps not (the example here is a 1.1 custom derive, but looking at 43230 I'm not sure if the filename makes sense, so I'm not convinced I know what it going on 100%) |
And the link to https://doc.servo.org/script/script_thread/struct.ScriptThread.html works. So I think this is fixed. @jdm please re-open if not. |
I'm receiving this error when trying to run rustdoc here: https://travis-ci.org/amethyst/website#L935 I'm unable to reproduce locally, but others on macos/linux have been able to. Unsure if this is related to this or not however. |
Running
./mach doc
on Servo's codebase yields a bunch of crates with the following warning:This means that the source is available for some types, but not others.
I'll try to figure out when this regressed.
The text was updated successfully, but these errors were encountered: