Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0623 not working for below examples #43875

Closed
gaurikholkar-zz opened this issue Aug 15, 2017 · 4 comments
Closed

E0623 not working for below examples #43875

gaurikholkar-zz opened this issue Aug 15, 2017 · 4 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@gaurikholkar-zz
Copy link

Example 1

struct Foo;

impl Foo {
    fn foo(&self, v: &mut Vec<&u32>, x: &u32) {
        v.push(x);
    }
}

Example 2

fn foo(v: &mut Vec<&u32>, x: &u32) {
    v.push(x);
}

Example 3

struct Foo;

impl Foo {
    fn foo(&self, x: &u32) -> &u32 {
        x
    }
}

cc @nikomatsakis

@Mark-Simulacrum Mark-Simulacrum added A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Aug 20, 2017
@gaurikholkar-zz
Copy link
Author

first two work now, third one will be fixed in an ongoing PR.

@gaurikholkar-zz
Copy link
Author

gaurikholkar-zz commented Sep 29, 2017

Waiting for #44124 to merge

@arielb1
Copy link
Contributor

arielb1 commented Oct 6, 2017

Merged in #44936.

@estebank
Copy link
Contributor

I believe the current output is reasonable for all the presented cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

4 participants