Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc style/theme/color picker doesn't work on Firefox #47695

Closed
CAD97 opened this issue Jan 24, 2018 · 6 comments
Closed

Rustdoc style/theme/color picker doesn't work on Firefox #47695

CAD97 opened this issue Jan 24, 2018 · 6 comments
Labels
P-high High priority T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@CAD97
Copy link
Contributor

CAD97 commented Jan 24, 2018 •
edited
Loading

A picture is worth a thousand words, so is this GIF a novel? (Chrome on left, Firefox 57.0.4 (64-bit) on right)
ezgif com-crop
(Windows 10 64-bit OS)
@CAD97
Copy link
Contributor Author

CAD97 commented Jan 24, 2018 •
edited
Loading

(Just updated to Firefox 58.0 (64-bit), and behavior is the same)

FWIW, I love that rustdoc now offers a dark CSS theme. It's just annoying that I can't switch, because I got used to the main one. Also, I only noticed it because Firefox defaulted to showing me the dark theme, whereas when I opened it in Chrome to compare, it defaulted to the main theme. And it's kind of jarring next to my darcula-themed editor.

@CAD97 CAD97 changed the title Rustdoc style picker doesn't work on FireFox Rustdoc style/theme/color picker doesn't work on FireFox Jan 24, 2018
@CAD97 CAD97 changed the title Rustdoc style/theme/color picker doesn't work on FireFox Rustdoc style/theme/color picker doesn't work on Firefox Jan 24, 2018
@retep998 retep998 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 24, 2018
@retep998
Copy link
Member

cc @GuillaumeGomez

@Centril
Copy link
Contributor

Centril commented Jan 24, 2018

Works on Chrome for me too but not on Firefox 59.0b3 (64-bit) Developer Edition on Windows 10.

@ehuss
Copy link
Contributor

ehuss commented Jan 24, 2018

I believe changing this from a <button> to a <div> would fix the problem.

@GuillaumeGomez
Copy link
Member

There is a PR in progress. I think it'll fix your issue. I'll test on firefox when I have time.

This was referenced Jan 24, 2018
Merged
Merged
@GuillaumeGomez
Copy link
Member

I confirm that this PR fixes the behavior on firefox.

@Mark-Simulacrum Mark-Simulacrum added the P-high High priority label Jan 25, 2018
bors added a commit that referenced this issue Jan 25, 2018
@bors
Auto merge of #47686 - GuillaumeGomez:theme-fixes, r=QuietMisdreavus
4cf26f8 
Few fixes for multiple themes support feature

r? @QuietMisdreavus

Fixes #47695.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-high High priority T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ehuss @retep998 @Centril @GuillaumeGomez @Mark-Simulacrum @CAD97