Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for RFC 2298, ? repetition in macro rules #48591

Closed
3 of 5 tasks
Centril opened this issue Feb 27, 2018 · 5 comments
Closed
3 of 5 tasks

Tracking issue for RFC 2298, ? repetition in macro rules #48591

Centril opened this issue Feb 27, 2018 · 5 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Feb 27, 2018 •
edited
Loading

This is a tracking issue for RFC 2298 (rust-lang/rfcs#2298).

Status

Known bugs

None.

Unresolved questions to be answered before stabilization

  • Should the ? Kleene operator accept a separator? Adding a separator is completely meaningless (since we don't accept trailing separators, and ? can accept "at most one" repetition), but allowing it is consistent with + and *. Currently, we allow a separator. We could also make it an error or lint.
@Centril Centril added B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. T-lang Relevant to the language team, which will review and decide on the PR/issue. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC labels Feb 27, 2018
@Centril Centril mentioned this issue Feb 27, 2018
Merged
@kennytm
Copy link
Member

kennytm commented Feb 27, 2018

🤔 Duplicate of #48075?

@mark-i-m
Copy link
Member

Yep it is a duplicate

@Centril Centril added B-unstable Blocker: Implemented in the nightly compiler and unstable. and removed B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. labels Feb 27, 2018
@Centril
Copy link
Contributor Author

Centril commented Feb 27, 2018 •
edited
Loading

Hmm... missed that tracking issue. I'll close that one since it is easier =)
( Copied the text from the other issue, .. )

@kennytm
Copy link
Member

kennytm commented Feb 27, 2018

The issue number in

rust/src/libsyntax/feature_gate.rs

Line 448 in 29f5c69

(active, macro_at_most_once_rep, "1.25.0", Some(48075)),
will need to be updated in this case...

@Centril
Copy link
Contributor Author

Centril commented Feb 27, 2018

Oh damn... Less work to fix the RFC I guess... reopening that one then. =P

@Centril Centril closed this as completed Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kennytm @Centril @mark-i-m