Documentation is flickering on light theme

[pravic]

I have noticed it with nightly and now it is in stable documentation.

It looks like a dark theme has become the default now, but users of the light one now are experiencing some very annoying flickering on each page load: it starts to load in dark theme and then switches to the light one.

Funny enough, it only happens with Chrome-based browsers (the old good Opera does not have this issue).

P.S. Firefox (Windows, Ubuntu) does not have such issue, too.

Is there a way to reduce such behavior? May be switch to the preferred theme a bit earlier?

@rust-lang/docs

[steveklabnik]

It looks like a dark theme has become the default now,

This should not be true. That said, what you're describing sounds bad... @GuillaumeGomez ?

[GuillaumeGomez]

It's not supposed to. By default, it is the light one which is selected.

[pravic]

Am I the only one who can see it? I tried different browsers and VMs, same here.

I'll check with devtools, what's going on there.

[pravic]

Well. The problem was with an unconditional theme switch, which was fixed in #48831. The current nightly works fine.

I doubt that that fix is possible to backport to the stable documentation, but may be at least in beta?

[steveklabnik]

Yeah, stable is impossible, but beta seems good.

[QuietMisdreavus]

As the fix PR was merged and backported (and a release has happened as well), i'm calling this issue fixed. Feel free to reopen if you disagree!

[pravic]

Yes, stable works good. Thanks!