Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nll] optimize access_place #51378

Closed
nikomatsakis opened this issue Jun 5, 2018 · 2 comments
Closed

[nll] optimize access_place #51378

nikomatsakis opened this issue Jun 5, 2018 · 2 comments
Assignees
@sapphire-arches
Labels
A-NLL Area: Non-lexical lifetimes (NLL) C-enhancement Category: An issue proposing an enhancement or a PR with one. NLL-performant Working towards the "performance is good" goal T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

Looking at profiles of clap-rs, access_place takes 4% of total execution time. For comparison, AST borrow check takes 2%, and does much more. Can we make it faster?
@nikomatsakis nikomatsakis added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-NLL Area: Non-lexical lifetimes (NLL) WG-compiler-nll NLL-performant Working towards the "performance is good" goal labels Jun 5, 2018
@nikomatsakis
Copy link
Contributor Author

cc @bobtwinkles

@sapphire-arches sapphire-arches self-assigned this Jun 6, 2018
@jkordish jkordish added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jun 12, 2018
@nikomatsakis
Copy link
Contributor Author

closing in favor of #51820 which I think is the "heart" of this function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sapphire-arches sapphire-arches

Labels
A-NLL Area: Non-lexical lifetimes (NLL) C-enhancement Category: An issue proposing an enhancement or a PR with one. NLL-performant Working towards the "performance is good" goal T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jkordish @nikomatsakis @sapphire-arches