Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.30 beta] tester crate broken #54466

Closed
pietroalbini opened this issue Sep 22, 2018 · 1 comment
Closed

[1.30 beta] tester crate broken #54466

pietroalbini opened this issue Sep 22, 2018 · 1 comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@pietroalbini
Copy link
Member

This regression will probably be marked as "won't fix". This issue notifies crate authors.

The tester crate doesn't work anymore on 1.30 beta. The rationale for this is in #53410 (comment).

@pietroalbini pietroalbini added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Sep 22, 2018
@pietroalbini pietroalbini added this to the 1.30 milestone Sep 22, 2018
@pnkfelix
Copy link
Member

pnkfelix commented Sep 27, 2018

Closing as WONTFIX based on previously linked reasoning #53410 (comment), transcribed below for posterity:

Also @alexcrichton it looks like I broke this: https://crates.io/crates/tester but I don't think that should have ever been allowable in the first place.

It used an implementation detail of how the compiler used libtest to test itself, to trick the stable compiler into thinking that tester was actually libtest and allow it to test itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants