Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: missing const values #55680

Closed
jnqnfe opened this issue Nov 4, 2018 · 3 comments
Closed

rustdoc: missing const values #55680

jnqnfe opened this issue Nov 4, 2018 · 3 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jnqnfe
Copy link
Contributor

jnqnfe commented Nov 4, 2018

Just noticed with 1.30 that generated documentation no longer shows values of constants, only their type. Was this a deliberate change or a regression?

Aplogies if already reported, I took a quick look and did not find, nor do I recall reading in blog post.

@frewsxcv
Copy link
Member

frewsxcv commented Nov 4, 2018

At least for associated constants, here's a relevant thread: #53409

@frewsxcv frewsxcv added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Nov 4, 2018
@QuietMisdreavus
Copy link
Member

The change was deliberate. Rustdoc got the rendering of the value directly from the compiler, and didn't try to hide things like private or #[doc(hidden)] fields, because it had no control over its rendering. The PR that @frewsxcv linked, (and its linked issue, #44348) contains farther discussion.

@jnqnfe
Copy link
Contributor Author

jnqnfe commented Nov 8, 2018

Oh, okay, thanks 👍

@jnqnfe jnqnfe closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants