Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: multiple matching crates #56901

Closed
Mark-Simulacrum opened this issue Dec 17, 2018 · 4 comments
Closed

rustdoc: multiple matching crates #56901

Mark-Simulacrum opened this issue Dec 17, 2018 · 4 comments
Labels
E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

https://crater-reports.s3.amazonaws.com/beta-1.32-1/beta-2018-12-05/reg/liquid-0.17.1/log.txt
https://crater-reports.s3.amazonaws.com/beta-1.32-1/beta-2018-12-05/reg/strip-ansi-escapes-0.1.0/log.txt

Dec 10 12:33:59.404 INFO [stdout] error[E0464]: multiple matching crates for `liquid`
Dec 10 12:33:59.404 INFO [stdout]  --> /source/README.md:24:1
Dec 10 12:33:59.404 INFO [stdout]   |
Dec 10 12:33:59.404 INFO [stdout] 2 | extern crate liquid;
Dec 10 12:33:59.404 INFO [stdout]   | ^^^^^^^^^^^^^^^^^^^^
Dec 10 12:33:59.404 INFO [stdout]   |
Dec 10 12:33:59.404 INFO [stdout]   = note: candidates:
Dec 10 12:33:59.404 INFO [stdout]           crate `liquid`: /target/debug/deps/libliquid-eeb578747bf01ff6.rlib
Dec 10 12:33:59.404 INFO [stdout]           crate `liquid`: /target/debug/deps/libliquid-83d4a9ea0668f274.rlib
Dec 10 12:33:59.404 INFO [stdout]           crate `liquid`: /target/debug/deps/libliquid-fb59e7eda215bc63.rlib
Dec 10 12:33:59.404 INFO [stdout]           crate `liquid`: /target/debug/deps/libliquid-7ede636d4e4a6eee.rlib
Dec 10 12:33:59.404 INFO [stdout] 
Dec 10 12:33:59.404 INFO [stdout] error[E0463]: can't find crate for `liquid`
Dec 10 12:33:59.404 INFO [stdout]  --> /source/README.md:24:1
Dec 10 12:33:59.404 INFO [stdout]   |
Dec 10 12:33:59.404 INFO [stdout] 2 | extern crate liquid;
Dec 10 12:33:59.404 INFO [stdout]   | ^^^^^^^^^^^^^^^^^^^^ can't find crate
Dec 10 12:33:59.404 INFO [stdout] 
@Mark-Simulacrum Mark-Simulacrum added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Dec 17, 2018
@pietroalbini
Copy link
Member

Ping @rust-lang/rustdoc, can someone look at this?

@QuietMisdreavus
Copy link
Member

Caused by #54939, cc @pnkfelix @alexcrichton

@alexcrichton
Copy link
Member

This seems like something that probably worked by luck before. I don't this is enough to revert #54939, so may just be a regression that slides.

@pietroalbini pietroalbini added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. and removed regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Apr 23, 2019
@jyn514
Copy link
Member

jyn514 commented Dec 16, 2020

This works fine on current stable:

running 2 tests
test /home/joshua/src/rust/test-rustdoc/liquid-rust/README.md - liquid_rust::Usage (line 24) ... ok
test /home/joshua/src/rust/test-rustdoc/liquid-rust/README.md - liquid_rust::Usage (line 30) ... ok

Should the issue be closed?

@jyn514 jyn514 added the E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example label Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants