Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INCOHERENT_AUTO_TRAIT_OBJECTS future-compatibility warning #57059

Closed
alexreg opened this issue Dec 22, 2018 · 2 comments
Closed

INCOHERENT_AUTO_TRAIT_OBJECTS future-compatibility warning #57059

alexreg opened this issue Dec 22, 2018 · 2 comments
Labels
C-future-incompatibility Category: Future-incompatibility lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@alexreg
Copy link
Contributor

alexreg commented Dec 22, 2018

This is the summary issue for the INCOHERENT_AUTO_TRAIT_OBJECTS
future-compatibility warning and other related errors. The goal of
this page is describe why this change was made and how you can fix
code that is affected by it. It also provides a place to ask questions
or register a complaint if you feel the change should not be made. For
more information on the policy around future-compatibility warnings,
see our breaking change policy guidelines.

What is the warning for?

Up to now there has been a bug in the de-duplication of auto traits in trait object bounds, such that the principal trait is not taken into account, meaning that impls of the same trait for, e.g., dyn Send and dyn Send + Send, are considered to be coherent, when in fact they should not be.

See #57057 for more details.

When will this warning become a hard error?

At the beginning of each 6-week release cycle, the Rust compiler team
will review the set of outstanding future compatibility warnings and
nominate some of them for Final Comment Period. Toward the end of
the cycle, we will review any comments and make a final determination
whether to convert the warning into a hard error or remove it
entirely.

@alexreg
Copy link
Contributor Author

alexreg commented Dec 22, 2018

CC @nikomatsakis @Centril @arielb1

@Centril Centril added T-lang Relevant to the language team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-future-incompatibility Category: Future-incompatibility lints labels Dec 22, 2018
@alexreg
Copy link
Contributor Author

alexreg commented Feb 1, 2019

This is superseded by #56481. Closing.

@alexreg alexreg closed this as completed Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-future-incompatibility Category: Future-incompatibility lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants