Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --no-run with doctests now there is --persist-doctests #59053

Closed
xd009642 opened this issue Mar 9, 2019 · 1 comment · Fixed by #83857
Closed

Use --no-run with doctests now there is --persist-doctests #59053

xd009642 opened this issue Mar 9, 2019 · 1 comment · Fixed by #83857
Assignees
@ABouttefeux
Labels
A-doctests Area: Documentation tests, run by rustdoc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@xd009642
Copy link
Contributor

xd009642 commented Mar 9, 2019 •
edited by rustbot
Loading

Now it is possible using unstable features to persist the doctest executables with --persist-doctests it should be possible to use --no-run with doctests when they aren't going to be deleted after the run.
@Centril Centril added the A-doctests Area: Documentation tests, run by rustdoc label Mar 10, 2019
@xd009642 xd009642 mentioned this issue Mar 10, 2019
Closed
@jyn514 jyn514 mentioned this issue Mar 8, 2021
Merged
@jyn514 jyn514 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 8, 2021
@ABouttefeux
Copy link
Contributor

@rustbot claim

@ABouttefeux ABouttefeux mentioned this issue Apr 4, 2021
Merged
@bors bors closed this as completed in 5f304a5 May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ABouttefeux ABouttefeux

Labels
A-doctests Area: Documentation tests, run by rustdoc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added --no-run option for rustdoc ABouttefeux/rust
4 participants
@Centril @xd009642 @jyn514 @ABouttefeux