Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls no longer builds after rust-lang/rust#60296 #60299

Closed
rust-highfive opened this issue Apr 26, 2019 · 7 comments
Closed

rls no longer builds after rust-lang/rust#60296 #60299

rust-highfive opened this issue Apr 26, 2019 · 7 comments
Assignees
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #60296, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Centril, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 26, 2019
@Centril
Copy link
Contributor

Centril commented Apr 26, 2019

I looked at the rollup but I don't know why this happened; it would be nice if highfive tried to highlight the source for each failed tool.

@phansch
Copy link
Member

phansch commented Apr 26, 2019

@Centril I think this may be because of Clippy not because of RLS as Clippy fails to compile since the rollup. I had a quick look but ran out of time for today. We essentially have to correctly handle the new ExprKind::Use in Clippy.

(also: the toolstate script doesn't seem to create the Clippy issue automatically?)

@Centril Centril removed their assignment Apr 26, 2019
@carols10cents
Copy link
Member

i'm not sure why the book failed either, is that because of clippy too? can you tell me where to look @phansch ?

@pnkfelix
Copy link
Member

pnkfelix commented May 2, 2019

(cc'ing #59761 since that proposes decoupling RLS from Clippy, which might lessen instances of this.)

@pnkfelix
Copy link
Member

pnkfelix commented May 2, 2019

triage: I do not know what priority to assign here. Leaving explicitly unprioritized and nominated for now (so that hopefully at rustc meeting we can collectively determine a priority).

@pnkfelix
Copy link
Member

pnkfelix commented May 2, 2019

but also, if the issue here is that Clippy needs to be updated, then shouldn't this be tagged with T-dev-tools? Adding that now.

@pnkfelix pnkfelix added the T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. label May 2, 2019
@Xanewok
Copy link
Member

Xanewok commented May 7, 2019

@pnkfelix can we close this specific issue? RLS is fixed and available again

@oli-obk oli-obk closed this as completed May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

7 participants