-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rls
no longer builds after rust-lang/rust#60296
#60299
Comments
I looked at the rollup but I don't know why this happened; it would be nice if highfive tried to highlight the source for each failed tool. |
@Centril I think this may be because of Clippy not because of RLS as Clippy fails to compile since the rollup. I had a quick look but ran out of time for today. We essentially have to correctly handle the new (also: the toolstate script doesn't seem to create the Clippy issue automatically?) |
i'm not sure why the book failed either, is that because of clippy too? can you tell me where to look @phansch ? |
(cc'ing #59761 since that proposes decoupling RLS from Clippy, which might lessen instances of this.) |
triage: I do not know what priority to assign here. Leaving explicitly unprioritized and nominated for now (so that hopefully at rustc meeting we can collectively determine a priority). |
but also, if the issue here is that Clippy needs to be updated, then shouldn't this be tagged with T-dev-tools? Adding that now. |
Hello, this is your friendly neighborhood mergebot.
After merging PR #60296, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.
cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!
cc @Centril, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
The text was updated successfully, but these errors were encountered: