Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TAU consts to f32 and f64 #66616

Closed
icefoxen opened this issue Nov 21, 2019 · 7 comments
Closed

Add TAU consts to f32 and f64 #66616

icefoxen opened this issue Nov 21, 2019 · 7 comments
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@icefoxen
Copy link
Contributor

icefoxen commented Nov 21, 2019

Where tau = 2 * pi.

In aesthetic terms, very much in the vein of ha-ha-only-serious, the argument is described here.

In practical terms, we already have const's for pi divided by various useful integers, so why not include multiplying it by the only really useful integer as well?

PR is trivial and already implemented in icefoxen@50173bd , but apparently I need a feature name and issue number and such associated with it, hence this ticket.

@jonas-schievink jonas-schievink added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Nov 21, 2019
@tesuji
Copy link
Contributor

tesuji commented Nov 22, 2019

Python and C/C++ doesn't seem to include that constant either.

@memoryruins
Copy link
Contributor

Python 3.6 added a tau constant, math.tau. Nim and Perl 6 include one as well.

@hellow554
Copy link
Contributor

@icefoxen without any guarantees, I'm sure it's pretty safe to just open a PR with an explanation and some reasoning and see what happens. To open an issue for asking is not necessary, just a tracking issue afterwards will be needed.

@ollie27
Copy link
Member

ollie27 commented Nov 22, 2019

See also: rust-lang/rfcs#1486

@Dylan-DPC-zz
Copy link

Closing this as it is easier to create a tracking issue when the rfc is accepted. Thanks

@est31
Copy link
Member

est31 commented Nov 26, 2019

Tracking issue: #66770

@steveklabnik
Copy link
Member

For posterity's sake, this was rejected back in #15248; any new RFCs would have to address that discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

9 participants