Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to LLVM{Get,Set}CurrentDebugLocation2. #68953

Closed
eddyb opened this issue Feb 8, 2020 · 2 comments
Closed

Switch to LLVM{Get,Set}CurrentDebugLocation2. #68953

eddyb opened this issue Feb 8, 2020 · 2 comments
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@eddyb
Copy link
Member

eddyb commented Feb 8, 2020

I'm still not fully sure what's going on, but see llvm/llvm-project@cce4741.

We would probably have to polyfill it on versions that don't have those APIs.
@eddyb eddyb added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) labels Feb 8, 2020
@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 8, 2020
@sanxiyn
Copy link
Member

sanxiyn commented Aug 18, 2022

Enough time has passed that all supported versions (>=13) now have the change.

@workingjubilee
Copy link
Member

Done in #109862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sanxiyn @eddyb @jonas-schievink @workingjubilee