Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc --check-theme doesn't work with minified theme #69071

Closed
Nemo157 opened this issue Feb 11, 2020 · 0 comments · Fixed by #69095
Closed

rustdoc --check-theme doesn't work with minified theme #69071

Nemo157 opened this issue Feb 11, 2020 · 0 comments · Fixed by #69095
Assignees
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Nemo157
Copy link
Member

Nemo157 commented Feb 11, 2020

In any crate running cargo doc && rustdoc --check-theme target/doc/light.css will emit a bunch of errors. If you take the css file and run it through something like prettier to get it to an unminified state then --check-theme will work fine.

Testing some manual minification of it one thing it appears to not like is , without a trailing space. Joining the h1, h2, lines into h1,h2, gives

  Missing "h1, h2, h3:not(.impl):not(.method):not(.type):not(.tymethod), h4:not(.method):not(.type):not(.tymethod)" rule

(cc @GuillaumeGomez)

@Nemo157 Nemo157 added the C-bug Category: This is a bug. label Feb 11, 2020
@GuillaumeGomez GuillaumeGomez self-assigned this Feb 12, 2020
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Feb 12, 2020
@bors bors closed this as completed in 839adda Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants