Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up src/librustdoc/markdown.rs render function #70498

Closed
GuillaumeGomez opened this issue Mar 28, 2020 · 0 comments · Fixed by #71900
Closed

Clean up src/librustdoc/markdown.rs render function #70498

GuillaumeGomez opened this issue Mar 28, 2020 · 0 comments · Fixed by #71900
Assignees
@GuillaumeGomez
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

It should return a Result/Option and not just an integer, it makes the code a bit confusing.
@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 28, 2020
@GuillaumeGomez GuillaumeGomez self-assigned this Mar 28, 2020
@GuillaumeGomez GuillaumeGomez mentioned this issue May 4, 2020
Merged
@bors bors closed this as completed in aeca4d6 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up rustdoc source code GuillaumeGomez/rust
1 participant
@GuillaumeGomez