Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow --set path.to.field=value in x.py itself #76616

Closed
jyn514 opened this issue Sep 11, 2020 · 3 comments
Closed

Allow --set path.to.field=value in x.py itself #76616

jyn514 opened this issue Sep 11, 2020 · 3 comments
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Sep 11, 2020

Right now, several options are duplicated between config.toml and CLI arguments to x.py itself (e.g. -i and incremental = true). It would be great make this consistent, so that all options can be either TOML options or CLI arguments. All existing arguments would still be present as aliases for the new behavior (so -i would alias to --set incremental=true).
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Sep 11, 2020
@jyn514 jyn514 mentioned this issue Sep 11, 2020
Closed
@jyn514
Copy link
Member Author

jyn514 commented Apr 30, 2021

@Mark-Simulacrum do you still think this would be useful?

@Mark-Simulacrum
Copy link
Member

Seems plausible to be helpful. No particular opinion; if it complicates the implementation quite a bit I wouldn't do it I suspect.

@jyn514
Copy link
Member Author

jyn514 commented Mar 29, 2022

I don't think this is super useful.

@jyn514 jyn514 closed this as completed Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mark-Simulacrum @jyn514