Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TupleStruct ctor privacy err diagnostic when working cross-crate #78708

Closed
guswynn opened this issue Nov 3, 2020 · 1 comment · Fixed by #85068
Closed

Improve TupleStruct ctor privacy err diagnostic when working cross-crate #78708

guswynn opened this issue Nov 3, 2020 · 1 comment · Fixed by #85068
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-visibility Area: Visibility / privacy T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@guswynn
Copy link
Contributor

guswynn commented Nov 3, 2020

currently
#78401
and
#76499

only work with types within the crate, as the struct_constructors only has full info for types within the current Crate being built
We can likely recover this info in the extern crate metadtata, but as reaching into this metadata is likely slow and complicated, this should only happen on the err path

I will see if I can find time to work on this

cc @estebank @petrochenkov

@rustbot modify labels to +T-lang, +A-diagnostics
@rustbot rustbot added A-diagnostics Area: Messages for errors, warnings, and lints T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Nov 3, 2020
@guswynn
Copy link
Contributor Author

guswynn commented Nov 3, 2020

@rustbot modify labels to +T-compiler, -T-lang

sorry!

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Nov 3, 2020
@camelid camelid added the A-visibility Area: Visibility / privacy label Nov 3, 2020
This was referenced May 8, 2021
Closed
Merged
@bors bors closed this as completed in 3db335b May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-visibility Area: Visibility / privacy T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix diagnostic for cross crate private tuple struct constructors luqmana/rust
3 participants
@guswynn @camelid @rustbot