Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate code that finds the return type of a future #78755

Open
tmandry opened this issue Nov 5, 2020 · 2 comments
Open

Deduplicate code that finds the return type of a future #78755

tmandry opened this issue Nov 5, 2020 · 2 comments
Labels
A-async-await Area: Async & Await AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@tmandry
Copy link
Member

tmandry commented Nov 5, 2020

I've noticed a lot of code being added to different parts of the compiler that all does the same thing.. gives you the return type of an async fn. This issue is to keep track of all those places and eventually deduplicate them.
@tmandry tmandry added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-async-await Area: Async & Await labels Nov 5, 2020
@tmandry tmandry mentioned this issue Nov 5, 2020
Merged
@guswynn
Copy link
Contributor

guswynn commented Nov 10, 2020

Oh I noticed this as well on #78297, forgot to make an issue for it!

@tmandry tmandry added the AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. label Dec 11, 2020
@tmandry
Copy link
Member Author

tmandry commented Dec 17, 2020 •
edited
Loading

Another place that was added: here in #76468

@guswynn guswynn mentioned this issue Dec 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-async-await Area: Async & Await AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmandry @guswynn