Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose a more reliable network clock source for the CI #78977

Closed
kennytm opened this issue Nov 12, 2020 · 2 comments
Closed

Choose a more reliable network clock source for the CI #78977

kennytm opened this issue Nov 12, 2020 · 2 comments
Labels
C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@kennytm
Copy link
Member

kennytm commented Nov 12, 2020

In #63511, we added a clock drift check using the Date: of http://detectportal.firefox.com/success.txt as reference. However, the reply is extremely unreliable recently (?), so we can't use it to detect any drift at all.

$ date -u; curl -fs --head http://detectportal.firefox.com/success.txt | grep Date
Thu Nov 12 10:49:23 UTC 2020
Date: Wed, 11 Nov 2020 12:48:07 GMT

$ date -u; curl -fs --head http://detectportal.firefox.com/success.txt | grep Date
Thu Nov 12 10:49:27 UTC 2020
Date: Thu, 12 Nov 2020 00:26:09 GMT

$ date -u; curl -fs --head http://detectportal.firefox.com/success.txt | grep Date
Thu Nov 12 10:49:30 UTC 2020
Date: Wed, 11 Nov 2020 12:48:07 GMT

$ date -u; curl -fs --head http://detectportal.firefox.com/success.txt | grep Date
Thu Nov 12 10:49:32 UTC 2020
Date: Thu, 12 Nov 2020 00:26:09 GMT
@kennytm kennytm added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Nov 12, 2020
@kennytm kennytm changed the title Choose a more reliable network clock source Choose a more reliable network clock source for the CI Nov 12, 2020
@Enselic
Copy link
Member

Enselic commented Dec 16, 2023

Triage: Is this still a problem?

@kennytm
Copy link
Member Author

kennytm commented Jan 8, 2024

already fixed from #90928.

@kennytm kennytm closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants