Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify download-* settings in config.toml #83369

Closed
jyn514 opened this issue Mar 22, 2021 · 3 comments
Closed

Unify download-* settings in config.toml #83369

jyn514 opened this issue Mar 22, 2021 · 3 comments
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Mar 22, 2021

Right now, there are two different download settings: download-ci-llvm and download-rustc. They are pretty similar and I imagine the knobs we'll want to tweak will be the same for both (e.g. it seems reasonable to add "if-unchanged" to download-ci-llvm now that download-rustc has it: #83368). Additionally, this could be extended without too much trouble to other tools and components, like rustdoc, clippy, etc. It would be nice to combine these together in to one option (maybe download-component). I'd expect the old options to work but give a warning to use the new syntax.

Another feature could be to support multiple requirements, or individual components:

  • download-component = "clippy,llvm"
  • download-component = "rustc=if-unchanged,llvm=if-available"
  • download-component = "if-unchanged,if-available"

cc @Mark-Simulacrum, #81930

@jyn514 jyn514 added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself labels Mar 22, 2021
@Mark-Simulacrum
Copy link
Member

I think unifying the backend implementation is OK. I don't care much about avoiding multiple options in the frontend; I think it's not necessarily bad but also seems like there's not much purpose to it - I guess I'm wondering why multiple options would be all that bad.

@camelid
Copy link
Member

camelid commented Mar 24, 2021

Semi-related: There's some inconsistency in naming because there's download-ci-llvm but also download-rustc. Not a big deal, but it seems like -ci- should be added to the latter or removed from the former.

@jyn514
Copy link
Member Author

jyn514 commented May 7, 2021

I don't think this is a very useful change.

@jyn514 jyn514 closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

3 participants