Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trait impls on type alias aren't documented on their underlying type #89452

Open
aDotInTheVoid opened this issue Oct 1, 2021 · 2 comments
Open

Trait impls on type alias aren't documented on their underlying type #89452

aDotInTheVoid opened this issue Oct 1, 2021 · 2 comments
Labels
A-trait-system Area: Trait system C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@aDotInTheVoid
Copy link
Member

aDotInTheVoid commented Oct 1, 2021 •
edited
Loading 

pub struct A;
pub type B = A;

pub trait T {}
impl T for B {}

image
image
image

This effects json and html

@rustbot modify labels: +C-Bug +T-rustdoc +A-rustdoc-json
@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 1, 2021
@aDotInTheVoid aDotInTheVoid mentioned this issue Oct 1, 2021
Closed
@aDotInTheVoid aDotInTheVoid changed the title Impls on type alias arnt documented on their underlying type Impls on type alias arn't documented on their underlying type Oct 1, 2021
@aDotInTheVoid
Copy link
Member Author 

pub struct A;
pub type B = A;

impl B {
    pub fn boo() {}
}

is handled correctly by html and json

@aDotInTheVoid aDotInTheVoid changed the title Impls on type alias arn't documented on their underlying type Trait impls on type alias arn't documented on their underlying type Oct 1, 2021
@camelid
Copy link
Member

camelid commented Oct 2, 2021

I'm going to remove the A-rustdoc-json label since this is not a bug with JSON; it is likely a bug with clean or similar that then gets outputted as HTML or JSON.

@camelid camelid added A-trait-system Area: Trait system and removed A-rustdoc-json Area: Rustdoc JSON backend labels Oct 2, 2021
@jsha jsha changed the title Trait impls on type alias arn't documented on their underlying type Trait impls on type alias aren't documented on their underlying type Oct 6, 2021
@rustbot rustbot added the A-rustdoc-json Area: Rustdoc JSON backend label Oct 6, 2021
@CraftSpider CraftSpider removed the A-rustdoc-json Area: Rustdoc JSON backend label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-trait-system Area: Trait system C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@CraftSpider @aDotInTheVoid @camelid @rustbot