Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x86_64-unknown-linux-musl: backport musl bug fixes or use new 1.2 version? #91178

Closed
haraldh opened this issue Nov 24, 2021 · 2 comments · Fixed by #107129
Closed

x86_64-unknown-linux-musl: backport musl bug fixes or use new 1.2 version? #91178

haraldh opened this issue Nov 24, 2021 · 2 comments · Fixed by #107129
Labels
C-bug Category: This is a bug. O-musl Target: The musl libc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@haraldh
Copy link
Contributor

haraldh commented Nov 24, 2021

Seems like x86_64-unknown-linux-musl is built with musl-1.1.24.

For this version I hit a bug, which is fixed with
https://git.musl-libc.org/cgit/musl/commit/?id=cb5babdc8d624a3e3e7bea0b4e28a677a2f2fc46
for the renamed src/malloc/malloc.c file.

What is the recommended procedure here?

Try to persuade upstream to release a fixed musl-1.1.25 or drive rust to switch to musl-1.2.x?
@haraldh haraldh mentioned this issue Nov 24, 2021
Open
6 tasks
@wesleywiser
Copy link
Member

Ideally, we would upgrade to the 1.2 series. It looks like there is a PR in progress to update the libc crate which is probably a dependency before we can perform the upgrade here (rust-lang/libc#2088).

@inquisitivecrystal inquisitivecrystal added C-bug Category: This is a bug. O-musl Target: The musl libc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 2, 2021
@Xuanwo
Copy link
Contributor

Xuanwo commented Jun 28, 2022

Also related to tikv/pprof-rs#142

@wesleywiser wesleywiser mentioned this issue Apr 26, 2023
Merged
@bors bors closed this as completed in 6e96802 May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. O-musl Target: The musl libc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the version of musl used on *-linux-musl targets to 1.2.3 wesleywiser/rust
4 participants
@haraldh @wesleywiser @Xuanwo @inquisitivecrystal