Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc regression: Lifetime in type alias definition is incorrectly elided #93401

Closed
camelid opened this issue Jan 28, 2022 · 8 comments · Fixed by #93542
Closed

rustdoc regression: Lifetime in type alias definition is incorrectly elided #93401

camelid opened this issue Jan 28, 2022 · 8 comments · Fixed by #93542
Labels
A-lifetimes Area: Lifetimes / regions C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Milestone

Comments

@camelid
Copy link
Member

camelid commented Jan 28, 2022

It'd be good to minimize this and reproduce this outside of rustc.

beta (incorrect)

image

stable (correct)

image

@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-lifetimes Area: Lifetimes / regions regression-from-stable-to-beta Performance or correctness regression from stable to beta. C-bug Category: This is a bug. labels Jan 28, 2022
@camelid camelid added this to the 1.59.0 milestone Jan 28, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jan 28, 2022
@inquisitivecrystal
Copy link
Contributor

inquisitivecrystal commented Jan 30, 2022

This bisects to #91430.

Stop looking at me like that! git bisect is still a thing! And no, before someone asks, I do not volunteer to do this sort of thing on a regular basis. It took all day. I did other stuff at the same time, but still...

@camelid
Copy link
Member Author

camelid commented Jan 30, 2022

Thank you so much! FYI, using cargo-bisect-rustc (with --prompt and -- doc --open) would've probably been a lot faster :)

@camelid
Copy link
Member Author

camelid commented Jan 30, 2022

cc @b-naber

@camelid
Copy link
Member Author

camelid commented Jan 30, 2022

I guess the issue here is that try_normalize_erasing_regions is erasing the lifetimes (=regions) in the type, hence its name.

cc @jackh726 as well

@GuillaumeGomez
Copy link
Member

I'm working on it.

@bors bors closed this as completed in 7e212c1 Feb 2, 2022
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Feb 2, 2022
@inquisitivecrystal
Copy link
Contributor

Thank you so much! FYI, using cargo-bisect-rustc (with --prompt and -- doc --open) would've probably been a lot faster :)

I feel very embarrassed. I figured that it wouldn't work, because generally cargo explodes whenever I try to use it on the compiler. I take it would actually work though?

@camelid
Copy link
Member Author

camelid commented Feb 3, 2022

Actually, I think you're right to use git bisect. cargo-bisect-rustc doesn't usually work on the compiler 🤦

Sorry about that!

@Mark-Simulacrum
Copy link
Member

The underlying principle should work though, by specifying rustc = ... in config.toml pointing to a rustup-toolchain-install-master'd binary (and potentially cargo = and/or rustdoc =).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lifetimes Area: Lifetimes / regions C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants