Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated dependency in tidy's deps.rs #93676

Closed
pierwill opened this issue Feb 5, 2022 · 1 comment · Fixed by #93863
Closed

Deprecated dependency in tidy's deps.rs #93676

pierwill opened this issue Feb 5, 2022 · 1 comment · Fixed by #93863
Assignees
Labels
C-bug Category: This is a bug.

Comments

@pierwill
Copy link
Member

pierwill commented Feb 5, 2022

According to crates.io, cpuid-bool is deprecated. However, it is listed in the permitted dependencies:

"cpuid-bool",

cpuid-bool is being pulled in by two hashing crates:

rust/Cargo.lock

Lines 4713 to 4737 in 4c55c83

[[package]]
name = "sha-1"
version = "0.9.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "170a36ea86c864a3f16dd2687712dd6646f7019f301e57537c7f4dc9f5916770"
dependencies = [
"block-buffer 0.9.0",
"cfg-if 0.1.10",
"cpuid-bool",
"digest 0.9.0",
"opaque-debug 0.3.0",
]
[[package]]
name = "sha2"
version = "0.9.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "2933378ddfeda7ea26f48c555bdad8bb446bf8a3d17832dc83e380d444cfb8c1"
dependencies = [
"block-buffer 0.9.0",
"cfg-if 0.1.10",
"cpuid-bool",
"digest 0.9.0",
"opaque-debug 0.3.0",
]

Both of these crates now use cpufeatures.

We should update sha2 and sha-1 to use the currently maintained crate.

@pierwill pierwill added the C-bug Category: This is a bug. label Feb 5, 2022
@pierwill
Copy link
Member Author

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant