Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment computing lint_levels by definition #95094

Closed
cjgillot opened this issue Mar 18, 2022 · 2 comments · Fixed by #101620
Closed

Experiment computing lint_levels by definition #95094

cjgillot opened this issue Mar 18, 2022 · 2 comments · Fixed by #101620
Assignees
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@cjgillot
Copy link
Contributor

cjgillot commented Mar 18, 2022

The lint_levels query traverses the whole crate to assign a set of lint and allowances to each HirId.

However, most incremental modifications to a crate don't involve many items. Computing lint_levels independently for each definition will help reduce the effect of recomputing it. The objective is to avoid lowering of some definitions once #88186 is merged.

Steps: not defined yet. Please make contact on Zulip to discuss and define them.

@cjgillot cjgillot added E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. labels Mar 18, 2022
@fbrunodr
Copy link

I have not contributed yet to rust, but I am willing to help if you want!

@fee1-dead
Copy link
Member

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
3 participants