Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[thread_local] on i686 windows msvc causes suspicious crash in production #95429

Closed
csmoe opened this issue Mar 29, 2022 · 5 comments · Fixed by #95430
Closed

#[thread_local] on i686 windows msvc causes suspicious crash in production #95429

csmoe opened this issue Mar 29, 2022 · 5 comments · Fixed by #95430
Labels
C-bug Category: This is a bug. O-windows Operating system: Windows O-windows-msvc Toolchain: MSVC, Operating system: Windows

Comments

@csmoe
Copy link
Member

csmoe commented Mar 29, 2022

As the title says, the crash disappeared once we set the has-thread-local = false on i686-pc-windows-msvc target spec.
Could we disable it? cc @nagisa
(the codebase is really huge, cannot generate a small test case)

#[thread_local] was enabled in #92042

@csmoe csmoe added O-windows Operating system: Windows O-windows-msvc Toolchain: MSVC, Operating system: Windows C-bug Category: This is a bug. labels Mar 29, 2022
@nagisa
Copy link
Member

nagisa commented Mar 29, 2022

cc @ChrisDenton

@ChrisDenton
Copy link
Member

Disabling it for i686 sounds reasonable if it's still causing issues. It is unfortunate we don't have a test case though.

I'll make a quick PR.

@nagisa
Copy link
Member

nagisa commented Mar 31, 2022

It would still be great if we could have a regression test case to put into our test suite, otherwise some time down the line somebody might end up re-enabling TLS on the affected platform again.

@bors bors closed this as completed in 46a4754 Apr 2, 2022
@thomcc
Copy link
Member

thomcc commented Sep 22, 2022

I wonder if the crash here is an example of the issue #101368 works around (or hopes to, anyway).

@Zoxc
Copy link
Contributor

Zoxc commented Apr 7, 2024

@csmoe Would you be able to reproduce this bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. O-windows Operating system: Windows O-windows-msvc Toolchain: MSVC, Operating system: Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants