-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#[thread_local] on i686 windows msvc causes suspicious crash in production #95429
Comments
cc @ChrisDenton |
Disabling it for i686 sounds reasonable if it's still causing issues. It is unfortunate we don't have a test case though. I'll make a quick PR. |
It would still be great if we could have a regression test case to put into our test suite, otherwise some time down the line somebody might end up re-enabling TLS on the affected platform again. |
I wonder if the crash here is an example of the issue #101368 works around (or hopes to, anyway). |
@csmoe Would you be able to reproduce this bug? |
As the title says, the crash disappeared once we set the
has-thread-local = false
on i686-pc-windows-msvc target spec.Could we disable it? cc @nagisa
(the codebase is really huge, cannot generate a small test case)
#[thread_local]
was enabled in #92042The text was updated successfully, but these errors were encountered: