-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to use cargo test
, not just x.py test
#95854
Comments
@rustbot label +E-mentor +E-medium +E-help-wanted |
If this isn't possible you could put an alias from |
@bjorn3 we should do that either way I think :) doesn't hurt and there's other commands we definitely can't support, like |
@rustbot claim |
Given the new entrypoints we're planning in https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/bootstrap.20user.20survey/near/283897117, I am not sure this still makes sense. @estebank I saw you left a ❤️ reaction - do you want to give feedback before I close the issue? |
@jyn514 I'm ok with the current direction. Familiarity for new contributors with the normal tooling would be useful, but maybe what is needed is to make cargo flexible enough for rustc, and not the other way around. |
I don't have a lot of confidence this is possible :( there's a thread in https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/why.20not.20.60cargo.20build.60.20in.20rust-lang.2Frust.3F where I explain some fundamental limitations cargo has. Anyway, I think having a mismatch between |
This sounds harder than it actually is, I think. We already have
default-members = ["bootstrap"]
in the root Cargo.toml, so we can implement this by adding an integration test insrc/bootstrap/tests
which callsbuilder.ensure(test::X)
for all possible values of X; ideally we would reuse the logic fromx.py test
exactly so thatcargo test
runs all tests,cargo test src/test/ui
runs UI tests, etc.cc #95253 (comment), #94829
@rustbot label +A-rustbuild +C-enhancement
The text was updated successfully, but these errors were encountered: