Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMING] debug output does not distinguish checking from building #96060

Closed
jyn514 opened this issue Apr 14, 2022 · 3 comments · Fixed by #96106
Closed

[TIMING] debug output does not distinguish checking from building #96060

jyn514 opened this issue Apr 14, 2022 · 3 comments · Fixed by #96106
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-enhancement Category: An issue proposing an enhancement or a PR with one. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Apr 14, 2022

While debugging the CI failure in #95450, I saw the following output in the logs:

2022-04-13T11:24:41.1948979Z [TIMING] Rustc { stage: 2, target: TargetSelection { triple: "x86_64-unknown-linux-gnu", file: None } } -- 113.867
2022-04-13T11:25:13.1594039Z [TIMING] Rustc { target: TargetSelection { triple: "x86_64-unknown-linux-gnu", file: None } } -- 31.963

The first one is doc::Rustc and the second I think is check::Rustc, by the fields it has. But we should just print that in the debug logs rather than having to guess.

@rustbot label +A-contributor-roadblock +C-enhancement

@rustbot rustbot added A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Apr 14, 2022
@jyn514
Copy link
Member Author

jyn514 commented Apr 15, 2022

This will be annoying to fix because we'll have to remove derive(Debug) for Step and implement it by hand. Maybe we could introduce a new macro making it easier? The module name is available through https://doc.rust-lang.org/stable/std/macro.module_path.html

@jyn514
Copy link
Member Author

jyn514 commented Apr 15, 2022

@rustbot label +E-medium +E-mentor +A-rustbuild

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Apr 15, 2022
@Mark-Simulacrum
Copy link
Member

The way to go is likely to add type_name to the timing print rather than solely relying on Debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-enhancement Category: An issue proposing an enhancement or a PR with one. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants