Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force parentheses around match expression in binary expression #108542

Merged
merged 3 commits into from
Mar 11, 2023
Merged

Force parentheses around match expression in binary expression #108542

merged 3 commits into from
Mar 11, 2023

Conversation

bwmf2
Copy link
Contributor

@bwmf2 bwmf2 commented Feb 27, 2023

This attempts to solve #98790.

@rustbot
Copy link
Collaborator

rustbot commented Feb 27, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wesleywiser (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 27, 2023
@compiler-errors
Copy link
Member

This needs a test

@bwmf2
Copy link
Contributor Author

bwmf2 commented Feb 28, 2023

I added the test.

wesleywiser
wesleywiser reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with the suggested comment added!

compiler/rustc_ast_pretty/src/pprust/state/expr.rs Show resolved Hide resolved
@wesleywiser wesleywiser added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2023
@bwmf2
Copy link
Contributor Author

bwmf2 commented Mar 3, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 3, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Mar 8, 2023

@bors r=wesleywiser

@bors
Copy link
Contributor

bors commented Mar 8, 2023

📌 Commit 219195f has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 8, 2023
@matthiaskrgr
Rollup merge of rust-lang#108542 - bwmf2:expanded, r=wesleywiser
838d3b8 
Force parentheses around `match` expression in binary expression

This attempts to solve rust-lang#98790.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 8, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 9, 2023
@matthiaskrgr
Rollup merge of rust-lang#108542 - bwmf2:expanded, r=wesleywiser
d02ed0a 
Force parentheses around `match` expression in binary expression

This attempts to solve rust-lang#98790.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 9, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2023
@matthiaskrgr
Rollup merge of rust-lang#108542 - bwmf2:expanded, r=wesleywiser
535305a 
Force parentheses around `match` expression in binary expression

This attempts to solve rust-lang#98790.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 10, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 11, 2023
@matthiaskrgr
Rollup merge of rust-lang#108542 - bwmf2:expanded, r=wesleywiser
d9a6aa8 
Force parentheses around `match` expression in binary expression

This attempts to solve rust-lang#98790.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 11, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 11, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2023
@bors
Auto merge of rust-lang#109019 - matthiaskrgr:rollup-ihjntil, r=matth…
8a73f50 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#104363 (Make `unused_allocation` lint against `Box::new` too)
 - rust-lang#106633 (Stabilize `nonzero_min_max`)
 - rust-lang#106844 (allow negative numeric literals in `concat!`)
 - rust-lang#108071 (Implement goal caching with the new solver)
 - rust-lang#108542 (Force parentheses around `match` expression in binary expression)
 - rust-lang#108690 (Place size limits on query keys and values)
 - rust-lang#108708 (Prevent overflow through Arc::downgrade)
 - rust-lang#108739 (Prevent the `start_bx` basic block in codegen from having two `Builder`s at the same time)
 - rust-lang#108806 (Querify register_tools and post-expansion early lints)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9c38ae5 into rust-lang:master Mar 11, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 11, 2023
@bwmf2 bwmf2 deleted the expanded branch March 11, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser left review comments

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
6 participants
@bwmf2 @rustbot @compiler-errors @oli-obk @bors @wesleywiser