Update E0424 to the new error format #35841
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -59,7 +59,7 @@ impl cat { | |||
| impl cat { | |||
| fn meow() { | |||
| if self.whiskers > 3 { | |||
| //~^ ERROR: `self` is not available in a static method. Maybe a `self` argument is missing? | |||
| //~^ ERROR: `self` is not available in a static method | |||
There was a problem hiding this comment.
Missing the note you added (like you did in E0424 file).
|
Ah, added that afterwards and forgot to check the diff of the first file. |
|
No problem. Please squash your commits and then I r+. |
Fixes #35797. Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
|
Squashed! |
|
Thanks! @bors: r+ rollup |
|
📌 Commit ff44f08 has been approved by |
…Gomez Update E0424 to the new error format Fixes rust-lang#35797. Part of rust-lang#35233. r? @GuillaumeGomez
…Gomez Update E0424 to the new error format Fixes rust-lang#35797. Part of rust-lang#35233. r? @GuillaumeGomez
…Gomez Update E0424 to the new error format Fixes rust-lang#35797. Part of rust-lang#35233. r? @GuillaumeGomez
|
☔ The latest upstream changes (presumably #35908) made this pull request unmergeable. Please resolve the merge conflicts. |
Fixes #35797.
Part of #35233.
r? @GuillaumeGomez