Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isize and usize constructors to Literal #43098

Merged
merged 1 commit into from
Jul 12, 2017
Merged

Add isize and usize constructors to Literal #43098

merged 1 commit into from
Jul 12, 2017

Conversation

alexcrichton
Copy link
Member

This commit fills out the remaining integer literal constructors on the
proc_macro::Literal type with isize and usize. (I think these were just
left out by accident)

@alexcrichton
Add isize and usize constructors to Literal
28ce292 
This commit fills out the remaining integer literal constructors on the
`proc_macro::Literal` type with `isize` and `usize`. (I think these were just
left out by accident)
@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned brson Jul 6, 2017
@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2017
@jseyfried
Copy link
Contributor

@alexcrichton Thanks, they were left out by accident!
@bors r+

@bors
Copy link
Contributor

bors commented Jul 11, 2017

📌 Commit 28ce292 has been approved by jseyfried

@arielb1
Copy link
Contributor

arielb1 commented Jul 11, 2017

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 12, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#43098 - alexcrichton:more-proc-macro, r=jse…
2510116 
…yfried

Add `isize` and `usize` constructors to Literal

This commit fills out the remaining integer literal constructors on the
`proc_macro::Literal` type with `isize` and `usize`. (I think these were just
left out by accident)
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 12, 2017
Merged
bors added a commit that referenced this pull request Jul 12, 2017
@bors
Auto merge of #43181 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
f85579d 
Rollup of 8 pull requests

- Successful merges: #42670, #42826, #43000, #43011, #43098, #43100, #43136, #43137
- Failed merges:
@bors bors merged commit 28ce292 into rust-lang:master Jul 12, 2017
@alexcrichton alexcrichton deleted the more-proc-macro branch July 24, 2017 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@alexcrichton @rust-highfive @jseyfried @bors @arielb1 @brson @shepmaster @nrc