Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use copy/clone closures to simplify calendar test #47305

Merged
merged 1 commit into from
Jan 12, 2018

Conversation

cramertj
Copy link
Member

Split out from #47304

r? @eddyb

eddyb
eddyb previously requested changes Jan 10, 2018
Copy link
Member

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit fixed

@@ -382,7 +349,7 @@ fn test_spaces() {
fn dates_in_year(year: i32) -> impl Iterator<Item=NaiveDate>+Clone {
InGroup {
it: NaiveDate::from_ymd(year, 1, 1)..,
f: (|d: &NaiveDate| d.year()).copyable(),
f: (|d: &NaiveDate| d.year()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the parens.

@cramertj cramertj force-pushed the better-calendar-alone branch from ed00572 to ce4673d Compare January 10, 2018 00:43
@kennytm kennytm dismissed eddyb’s stale review January 10, 2018 12:40

Nit is fixed

@kennytm
Copy link
Member

kennytm commented Jan 10, 2018

@bors r=eddyb

@bors
Copy link
Contributor

bors commented Jan 10, 2018

📌 Commit ce4673d has been approved by eddyb

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 10, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Jan 11, 2018
…ddyb

Use copy/clone closures to simplify calendar test

Split out from rust-lang#47304

r? @eddyb
kennytm added a commit to kennytm/rust that referenced this pull request Jan 11, 2018
…ddyb

Use copy/clone closures to simplify calendar test

Split out from rust-lang#47304

r? @eddyb
bors added a commit that referenced this pull request Jan 11, 2018
Rollup of 12 pull requests

- Successful merges: #47283, #47288, #47289, #47298, #47305, #47307, #47310, #47322, #47324, #47328, #47340, #47344
- Failed merges:
bors added a commit that referenced this pull request Jan 12, 2018
Rollup of 12 pull requests

- Successful merges: #47283, #47288, #47289, #47298, #47305, #47307, #47310, #47322, #47324, #47328, #47340, #47344
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Jan 12, 2018
…ddyb

Use copy/clone closures to simplify calendar test

Split out from rust-lang#47304

r? @eddyb
bors added a commit that referenced this pull request Jan 12, 2018
@bors bors merged commit ce4673d into rust-lang:master Jan 12, 2018
@cramertj cramertj deleted the better-calendar-alone branch January 12, 2018 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants