Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed broken links to char #53052

Merged
merged 2 commits into from
Aug 7, 2018
Merged

fixed broken links to char #53052

merged 2 commits into from
Aug 7, 2018

Conversation

r3drock
Copy link
Contributor

@r3drock r3drock commented Aug 4, 2018

fixes #32129

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @shepmaster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2018
@r3drock
Copy link
Contributor Author

r3drock commented Aug 4, 2018

The only problem with the links was that the wrong folder was referenced.

@estebank
Copy link
Contributor

estebank commented Aug 4, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Aug 4, 2018

📌 Commit 33483fa has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2018
@rust-highfive

This comment has been minimized.

Sign in to view
@QuietMisdreavus
Copy link
Member

Writing those links like that now breaks them when they appear on the page for &str. The reason i said that we may be able to fix them now is that we can use the "intra doc links" to reference char instead of linking to the page. Try removing the lines you changed entirely. That should cause rustdoc to link to the primitive by referencing its type, rather than trying to reference its page.

@kennytm
Copy link
Member

kennytm commented Aug 4, 2018

@bors r-

Broken links, see the comment above.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 4, 2018
@killercup
Copy link
Member

killercup commented Aug 4, 2018 •
edited
Loading

Do we have a way to assert this works without checking it out locally?

Assuming that it does work, can I r=QuietMisdreavus this?

@QuietMisdreavus
Copy link
Member

Seeing as linkchecker failed the first time, and passed this time, i'm okay with assuming this works. I tried building it locally, but i got an unrelated build error when it tried to document (no idea what's going on there). Since it worked for travis, let's see if it works for bors.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 5, 2018

📌 Commit 6169707 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 5, 2018
@shepmaster
Copy link
Member

r? @QuietMisdreavus

kennytm added a commit to kennytm/rust that referenced this pull request Aug 7, 2018
@kennytm
Rollup merge of rust-lang#53052 - redroc:master, r=QuietMisdreavus
b1ca710 
fixed broken links to char

fixes rust-lang#32129
@kennytm kennytm mentioned this pull request Aug 7, 2018
Merged
bors added a commit that referenced this pull request Aug 7, 2018
@bors
Auto merge of #53150 - kennytm:rollup, r=kennytm
18925de 
Rollup of 10 pull requests

Successful merges:

 - #52885 (Remove some unused method arguments from typeck)
 - #52886 (cleanup: Remove `Def::GlobalAsm`)
 - #53028 (Building librustc_codegen_llvm in a separate directory)
 - #53052 (fixed broken links to char)
 - #53060 (Change rustdoc style so fully qualified name does not overlap src link)
 - #53068 (Rename Executor trait to Spawn)
 - #53093 (Enable macros to pass $:literal to another macro)
 - #53107 (Remove references to `StaticMutex` which got removed a while ago)
 - #53135 (Rust 2018: Disable catch_expr, not targeted for 2018 edition)
 - #53139 (set emit_debug_gdb_scripts: false for riscv32imac-unknown-none target)
@bors bors merged commit 6169707 into rust-lang:master Aug 7, 2018
@pnkfelix pnkfelix mentioned this pull request Oct 8, 2018
Closed
@tspiteri tspiteri mentioned this pull request Feb 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken links in String documentation from Deref impl
8 participants
@r3drock @rust-highfive @estebank @bors @QuietMisdreavus @kennytm @killercup @shepmaster