Don't arena-allocate static symbols. #61077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Haha, nice idea. Minimized even further: fn prefill(init: &[&'static str]) -> Self {
Interner {
strings: init.into(),
names: init.iter().copied().zip((0..).map(Symbol::new)).collect(),
..Default::default()
}
} |
petrochenkov
added
S-waiting-on-author
|
Today I learned that |
nnethercote
force-pushed
the
tweak-prefill
branch
from
c3bf807 to
c4f48b3
Compare
|
@petrochenkov: I have updated the code. |
|
Looks like the changes were not pushed to github. |
It's just a waste of memory. This also gets rid of the special case for "".
nnethercote
force-pushed
the
tweak-prefill
branch
from
c4f48b3 to
e396f99
Compare
|
Ok, changes are pushed now! Sorry about that. |
|
Thanks! |
|
📌 Commit e396f99 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 24, 2019
…henkov Don't arena-allocate static symbols. It's just a waste of memory. This also gets rid of the special case for "". r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 24, 2019
…henkov Don't arena-allocate static symbols. It's just a waste of memory. This also gets rid of the special case for "". r? @petrochenkov
bors
added a commit
that referenced
this pull request
May 24, 2019
Rollup of 13 pull requests Successful merges: - #61077 (Don't arena-allocate static symbols.) - #61094 (Make find_local iterate instead of recurse) - #61095 (Update cargo) - #61096 (tidy: don't short-circuit on license error) - #61103 (Make find iterate instead of recurse) - #61104 (Make eval_place_to_op iterate instead of recurse) - #61107 (Fix a couple docs typos) - #61110 (Revert edition-guide toolstate override) - #61111 (Fixed type-alias-bounds lint doc) - #61113 (Deprecate `FnBox`. `Box<dyn FnOnce()>` can be called directly, since 1.35) - #61116 (Remove the incorrect warning from README.md) - #61118 (Dont ICE on an attempt to use GAT without feature gate) - #61125 (Updated my mailmap entry) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 24, 2019
…henkov Don't arena-allocate static symbols. It's just a waste of memory. This also gets rid of the special case for "". r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 25, 2019
…henkov Don't arena-allocate static symbols. It's just a waste of memory. This also gets rid of the special case for "". r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 25, 2019
Rollup of 5 pull requests Successful merges: - rust-lang#60928 (Changes the type `mir::Mir` into `mir::Body`) - rust-lang#61035 (Avoid more symbol interning) - rust-lang#61036 (PGO - Add a smoketest for combining PGO with cross-language LTO.) - rust-lang#61077 (Don't arena-allocate static symbols.) - rust-lang#61080 (Ship profiler with windows-gnu) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 25, 2019
…henkov Don't arena-allocate static symbols. It's just a waste of memory. This also gets rid of the special case for "". r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 25, 2019
…henkov Don't arena-allocate static symbols. It's just a waste of memory. This also gets rid of the special case for "". r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 25, 2019
…henkov Don't arena-allocate static symbols. It's just a waste of memory. This also gets rid of the special case for "". r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 25, 2019
…henkov Don't arena-allocate static symbols. It's just a waste of memory. This also gets rid of the special case for "". r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 26, 2019
…henkov Don't arena-allocate static symbols. It's just a waste of memory. This also gets rid of the special case for "". r? @petrochenkov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just a waste of memory. This also gets rid of the special case for
"".
r? @petrochenkov