Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] see what breaks when we remove this recursive-enum-discriminants hack #61723

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] see what breaks when we remove this recursive-enum-discriminants hack #61723

wants to merge 1 commit into from

Conversation

RalfJung
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2019
@RalfJung RalfJung mentioned this pull request Jun 10, 2019
Merged
@RalfJung
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jun 10, 2019

⌛ Trying commit ca7c9b1 with merge f6d4098...

bors added a commit that referenced this pull request Jun 10, 2019
@bors
Auto merge of #61723 - RalfJung:no-more-recursive-enums, r=<try>
f6d4098 
[DO NOT MERGE] see what breaks when we remove this recursive-enum-discriminants check
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:220fce08:start=1560186087293135422,finish=1560186088102498570,duration=809363148
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:55:20] .................................................................................................... 400/5666
[00:55:24] .................................................................................................... 500/5666
[00:55:27] ...................................i................................................................ 600/5666
[00:55:31] .................................................................................................... 700/5666
[00:55:36] ..............................................................................F..................... 800/5666
[00:55:40] .....................................................F.............................................. 900/5666
[00:55:48] ................................................................iiiii............................... 1100/5666
[00:55:52] .................................................................................................... 1200/5666
[00:55:54] .................................................................................................... 1300/5666
[00:55:56] .................................................................................................... 1400/5666
---
[00:56:15] .................................................................................................... 2000/5666
[00:56:19] .................................................................................................... 2100/5666
[00:56:22] .....................................i.............................................................. 2200/5666
[00:56:26] .................................................................................................... 2300/5666
[00:56:30] ...........................................................................F.F...................... 2400/5666
[00:56:38] .................................................................................................... 2600/5666
[00:56:38] .................................................................................................... 2600/5666
[00:56:42] .............................................................F...................................... 2700/5666
[00:56:45] ...........................................................F........................................ 2800/5666
[00:56:54] .................................................................................................... 3000/5666
[00:56:58] .................................................................................................... 3100/5666
[00:57:00] .................................................................................................... 3200/5666
[00:57:05] .................................................................................................... 3300/5666
---
[00:58:39] failures:
[00:58:39] 
[00:58:39] ---- [ui] ui/consts/const-eval/enum_discr.rs stdout ----
[00:58:39] 
[00:58:39] error: test compilation failed although it shouldn't!
[00:58:39] status: exit code: 1
[00:58:39] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/const-eval/enum_discr.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/enum_discr/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/enum_discr/auxiliary" "-A" "unused"
[00:58:39] ------------------------------------------
[00:58:39] 
[00:58:39] ------------------------------------------
[00:58:39] stderr:
[00:58:39] stderr:
[00:58:39] ------------------------------------------
[00:58:39] error[E0391]: cycle detected when const-evaluating + checking `Foo::Y::{{constant}}#0`
[00:58:39]    |
[00:58:39]    |
[00:58:39] LL |     Y = Foo::X as isize - 3,
[00:58:39]    |
[00:58:39]    |
[00:58:39] note: ...which requires const-evaluating `Foo::Y::{{constant}}#0`...
[00:58:39]    |
[00:58:39]    |
[00:58:39] LL |     Y = Foo::X as isize - 3,
[00:58:39]    |         ^^^^^^
[00:58:39]    = note: ...which requires computing layout of `Foo`...
[00:58:39]    = note: ...which again requires const-evaluating + checking `Foo::Y::{{constant}}#0`, completing the cycle
[00:58:39] note: cycle used when collecting item types in top-level module
[00:58:39]    |
[00:58:39] LL | enum Foo {
[00:58:39]    | ^^^^^^^^
[00:58:39] 
---
[00:58:39] ---- [ui] ui/consts/const-prop-ice2.rs stdout ----
[00:58:39] 
[00:58:39] error: ui test compiled successfully!
[00:58:39] status: exit code: 0
[00:58:39] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/const-prop-ice2.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-prop-ice2" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-prop-ice2/auxiliary" "-A" "unused"
[00:58:39] ------------------------------------------
[00:58:39] 
[00:58:39] ------------------------------------------
[00:58:39] stderr:
---
[00:58:39] 
[00:58:39] ---- [ui] ui/issues/issue-23302-1.rs stdout ----
[00:58:39] diff of stderr:
[00:58:39] 
[00:58:39] - error[E0391]: cycle detected when processing `X::A::{{constant}}#0`
[00:58:39] + error[E0391]: cycle detected when const-evaluating + checking `X::A::{{constant}}#0`
[00:58:39] 3    |
[00:58:39] 3    |
[00:58:39] 4 LL |     A = X::A as isize,
[00:58:39] 5    |         ^^^^^^^^^^^^^
[00:58:39] 6    |
[00:58:39] 6    |
[00:58:39] -    = note: ...which again requires processing `X::A::{{constant}}#0`, completing the cycle
[00:58:39] - note: cycle used when processing `X::A::{{constant}}#0`
[00:58:39] + note: ...which requires const-evaluating `X::A::{{constant}}#0`...
[00:58:39] 10    |
[00:58:39] 10    |
[00:58:39] 11 LL |     A = X::A as isize,
[00:58:39] 12    |         ^^^^^^^^^^^^^
[00:58:39] 12    |         ^^^^^^^^^^^^^
[00:58:39] +    = note: ...which again requires const-evaluating + checking `X::A::{{constant}}#0`, completing the cycle
[00:58:39] + note: cycle used when collecting item types in top-level module
[00:58:39] +    |
[00:58:39] +    |
[00:58:39] + LL | enum X {
[00:58:39] 13 
[00:58:39] 14 error: aborting due to previous error
[00:58:39] 15 
[00:58:39] 
[00:58:39] 
[00:58:39] 
[00:58:39] The actual stderr differed from the expected stderr.
[00:58:39] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-23302-1/issue-23302-1.stderr
[00:58:39] To update references, rerun the tests and pass the `--bless` flag
[00:58:39] To only update this specific test, also pass `--test-args issues/issue-23302-1.rs`
[00:58:39] error: 1 errors occurred comparing output.
[00:58:39] status: exit code: 1
[00:58:39] status: exit code: 1
[00:58:39] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-23302-1.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-23302-1" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-23302-1/auxiliary" "-A" "unused"
[00:58:39] ------------------------------------------
[00:58:39] 
[00:58:39] ------------------------------------------
[00:58:39] stderr:
[00:58:39] stderr:
[00:58:39] ------------------------------------------
[00:58:39] error[E0391]: cycle detected when const-evaluating + checking `X::A::{{constant}}#0`
[00:58:39]    |
[00:58:39]    |
[00:58:39] LL |     A = X::A as isize, //~ ERROR E0391
[00:58:39]    |
[00:58:39]    |
[00:58:39] note: ...which requires const-evaluating `X::A::{{constant}}#0`...
[00:58:39]    |
[00:58:39]    |
[00:58:39] LL |     A = X::A as isize, //~ ERROR E0391
[00:58:39]    |         ^^^^^^^^^^^^^
[00:58:39]    = note: ...which again requires const-evaluating + checking `X::A::{{constant}}#0`, completing the cycle
[00:58:39] note: cycle used when collecting item types in top-level module
[00:58:39]    |
[00:58:39]    |
[00:58:39] LL | enum X {
[00:58:39] 
[00:58:39] error: aborting due to previous error
[00:58:39] 
[00:58:39] For more information about this error, try `rustc --explain E0391`.
[00:58:39] For more information about this error, try `rustc --explain E0391`.
[00:58:39] 
[00:58:39] ------------------------------------------
[00:58:39] 
[00:58:39] 
[00:58:39] ---- [ui] ui/issues/issue-23302-2.rs stdout ----
[00:58:39] diff of stderr:
[00:58:39] 
[00:58:39] - error[E0391]: cycle detected when processing `Y::A::{{constant}}#0`
[00:58:39] + error[E0391]: cycle detected when const-evaluating + checking `Y::A::{{constant}}#0`
[00:58:39] 3    |
[00:58:39] 3    |
[00:58:39] 4 LL |     A = Y::B as isize,
[00:58:39] 5    |         ^^^^^^^^^^^^^
[00:58:39] 6    |
[00:58:39] 6    |
[00:58:39] -    = note: ...which again requires processing `Y::A::{{constant}}#0`, completing the cycle
[00:58:39] - note: cycle used when processing `Y::A::{{constant}}#0`
[00:58:39] + note: ...which requires const-evaluating `Y::A::{{constant}}#0`...
[00:58:39] 10    |
[00:58:39] 10    |
[00:58:39] 11 LL |     A = Y::B as isize,
[00:58:39] -    |         ^^^^^^^^^^^^^
[00:58:39] +    |         ^^^^
[00:58:39] +    |         ^^^^
[00:58:39] +    = note: ...which requires computing layout of `Y`...
[00:58:39] +    = note: ...which again requires const-evaluating + checking `Y::A::{{constant}}#0`, completing the cycle
[00:58:39] + note: cycle used when collecting item types in top-level module
[00:58:39] +    |
[00:58:39] +    |
[00:58:39] + LL | enum Y {
[00:58:39] 13 
[00:58:39] 14 error: aborting due to previous error
[00:58:39] 15 
[00:58:39] 
[00:58:39] 
[00:58:39] 
[00:58:39] The actual stderr differed from the expected stderr.
[00:58:39] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-23302-2/issue-23302-2.stderr
[00:58:39] To update references, rerun the tests and pass the `--bless` flag
[00:58:39] To only update this specific test, also pass `--test-args issues/issue-23302-2.rs`
[00:58:39] error: 1 errors occurred comparing output.
[00:58:39] status: exit code: 1
[00:58:39] status: exit code: 1
[00:58:39] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-23302-2.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-23302-2" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-23302-2/auxiliary" "-A" "unused"
[00:58:39] ------------------------------------------
[00:58:39] 
[00:58:39] ------------------------------------------
[00:58:39] stderr:
[00:58:39] stderr:
[00:58:39] ------------------------------------------
[00:58:39] error[E0391]: cycle detected when const-evaluating + checking `Y::A::{{constant}}#0`
[00:58:39]    |
[00:58:39]    |
[00:58:39] LL |     A = Y::B as isize, //~ ERROR E0391
[00:58:39]    |
[00:58:39]    |
[00:58:39] note: ...which requires const-evaluating `Y::A::{{constant}}#0`...
[00:58:39]    |
[00:58:39]    |
[00:58:39] LL |     A = Y::B as isize, //~ ERROR E0391
[00:58:39]    |         ^^^^
[00:58:39]    = note: ...which requires computing layout of `Y`...
[00:58:39]    = note: ...which again requires const-evaluating + checking `Y::A::{{constant}}#0`, completing the cycle
[00:58:39] note: cycle used when collecting item types in top-level module
[00:58:39]    |
[00:58:39]    |
[00:58:39] LL | enum Y {
[00:58:39] 
[00:58:39] error: aborting due to previous error
[00:58:39] 
[00:58:39] For more information about this error, try `rustc --explain E0391`.
[00:58:39] For more information about this error, try `rustc --explain E0391`.
[00:58:39] 
[00:58:39] ------------------------------------------
[00:58:39] 
[00:58:39] 
[00:58:39] ---- [ui] ui/issues/issue-36163.rs stdout ----
[00:58:39] diff of stderr:
[00:58:39] 
[00:58:39] - error[E0391]: cycle detected when processing `Foo::B::{{constant}}#0`
[00:58:39] + error[E0391]: cycle detected when const-evaluating + checking `Foo::B::{{constant}}#0`
[00:58:39] 3    |
[00:58:39] 4 LL |     B = A,
[00:58:39] 
[00:58:39] 5    |         ^
[00:58:39] 5    |         ^
[00:58:39] 6    |
[00:58:39] - note: ...which requires processing `A`...
[00:58:39] -    |
[00:58:39] -    |
[00:58:39] - LL | const A: isize = Foo::B as isize;
[00:58:39] -    |                  ^^^^^^^^^^^^^^^
[00:58:39] -    = note: ...which again requires processing `Foo::B::{{constant}}#0`, completing the cycle
[00:58:39] - note: cycle used when processing `Foo::B::{{constant}}#0`
[00:58:39] + note: ...which requires const-evaluating `Foo::B::{{constant}}#0`...
[00:58:39] 15    |
[00:58:39] 16 LL |     B = A,
[00:58:39] 
[00:58:39] 17    |         ^
[00:58:39] 17    |         ^
[00:58:39] + note: ...which requires const-evaluating `A`...
[00:58:39] +    |
[00:58:39] +    |
[00:58:39] + LL | const A: isize = Foo::B as isize;
[00:58:39] +    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:58:39] +    = note: ...which again requires const-evaluating + checking `Foo::B::{{constant}}#0`, completing the cycle
[00:58:39] + note: cycle used when collecting item types in top-level module
[00:58:39] +    |
[00:58:39] +    |
[00:58:39] + LL | / const A: isize = Foo::B as isize;
[00:58:39] + LL | |
[00:58:39] + LL | | enum Foo {
[00:58:39] + LL | |     B = A,
[00:58:39] + LL | | }
[00:58:39] + LL | |
[00:58:39] + LL | | fn main() {}
[00:58:39] 18 
[00:58:39] 19 error: aborting due to previous error
[00:58:39] 20 
[00:58:39] 
[00:58:39] 
[00:58:39] 
[00:58:39] The actual stderr differed from the expected stderr.
[00:58:39] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-36163/issue-36163.stderr
[00:58:39] To update references, rerun the tests and pass the `--bless` flag
[00:58:39] To only update this specific test, also pass `--test-args issues/issue-36163.rs`
[00:58:39] error: 1 errors occurred comparing output.
[00:58:39] status: exit code: 1
[00:58:39] status: exit code: 1
[00:58:39] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-36163.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-36163" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-36163/auxiliary" "-A" "unused"
[00:58:39] ------------------------------------------
[00:58:39] 
[00:58:39] ------------------------------------------
[00:58:39] stderr:
[00:58:39] stderr:
[00:58:39] ------------------------------------------
[00:58:39] error[E0391]: cycle detected when const-evaluating + checking `Foo::B::{{constant}}#0`
[00:58:39]    |
[00:58:39]    |
[00:58:39] LL |     B = A, //~ ERROR E0391
[00:58:39]    |
[00:58:39]    |
[00:58:39] note: ...which requires const-evaluating `Foo::B::{{constant}}#0`...
[00:58:39]    |
[00:58:39]    |
[00:58:39] LL |     B = A, //~ ERROR E0391
[00:58:39]    |         ^
[00:58:39] note: ...which requires const-evaluating `A`...
[00:58:39]    |
[00:58:39]    |
[00:58:39] LL | const A: isize = Foo::B as isize;
[00:58:39]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:58:39]    = note: ...which again requires const-evaluating + checking `Foo::B::{{constant}}#0`, completing the cycle
[00:58:39] note: cycle used when collecting item types in top-level module
[00:58:39]    |
[00:58:39]    |
[00:58:39] LL | / const A: isize = Foo::B as isize;
[00:58:39] LL | | enum Foo {
[00:58:39] LL | | enum Foo {
[00:58:39] LL | |     B = A, //~ ERROR E0391
[00:58:39] LL | |
[00:58:39] LL | | fn main() {}
[00:58:39]    | |____________^
[00:58:39] 
---
[00:58:39] 10 
[00:58:39] - error[E0080]: evaluation of constant value failed
[00:58:39] -   --> $DIR/issue-41394.rs:7:9
[00:58:39] -    |
[00:58:39] - LL |     A = Foo::A as isize
[00:58:39] -    |         ^^^^^^^^^^^^^^^ referenced constant has errors
[00:58:39] + error: aborting due to previous error
[00:58:39] - error: aborting due to 2 previous errors
[00:58:39] - 
[00:58:39] - Some errors have detailed explanations: E0080, E0369.
[00:58:39] - For more information about an error, try `rustc --explain E0080`.
[00:58:39] - For more information about an error, try `rustc --explain E0080`.
[00:58:39] + For more information about this error, try `rustc --explain E0369`.
[00:58:39] 21 
[00:58:39] 
[00:58:39] 
[00:58:39] The actual stderr differed from the expected stderr.
[00:58:39] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-41394/issue-41394.stderr
[00:58:39] To update references, rerun the tests and pass the `--bless` flag
[00:58:39] To only update this specific test, also pass `--test-args issues/issue-41394.rs`
[00:58:39] error: 1 errors occurred comparing output.
[00:58:39] status: exit code: 1
[00:58:39] status: exit code: 1
[00:58:39] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-41394.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-41394" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-41394/auxiliary" "-A" "unused"
[00:58:39] ------------------------------------------
[00:58:39] 
[00:58:39] ------------------------------------------
[00:58:39] stderr:
[00:58:39] stderr:
[00:58:39] ------------------------------------------
[00:58:39] error[E0369]: binary operation `+` cannot be applied to type `&str`
[00:58:39]    |
[00:58:39]    |
[00:58:39] LL |     A = "" + 1
[00:58:39]    |         -- ^ - {integer}
[00:58:39]    |         &str
[00:58:39]    |
[00:58:39]    = note: an implementation of `std::ops::Add` might be missing for `&str`
[00:58:39] 
---
[00:58:39] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:521:22
[00:58:39] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[00:58:39] 
[00:58:39] 
[00:58:39] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:58:39] 
[00:58:39] 
[00:58:39] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:58:39] Build completed unsuccessfully in 0:53:46
---
travis_time:end:0921742c:start=1560189619341171649,finish=1560189619346163769,duration=4992120
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2b789137
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:2dbfc042
travis_time:start:2dbfc042
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:183d8b60
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Jun 10, 2019

☀️ Try build successful - checks-travis
Build commit: f6d4098

@RalfJung RalfJung changed the title [DO NOT MERGE] see what breaks when we remove this recursive-enum-discriminants check [DO NOT MERGE] see what breaks when we remove this recursive-enum-discriminants hack Jun 10, 2019
@RalfJung
Copy link
Member Author

@rust-lang/infra could we get a check-only crater run for this?

@estebank
Copy link
Contributor

@craterbot run mode=check-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-61723 created and queued.
🤖 Automatically detected try build f6d4098
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Jun 11, 2019

There's no point in cratering this. Certain old winapi versions that are in use will fail, but they won't be tested on crater.

see #49765 and linked issues/PRs

@RalfJung
Copy link
Member Author

Seriously, winapi? 😢

Do you think there is any point in issuing a deprecation warning such that, maybe in a year or two we can remove this accidental feature? (I am still assuming this is an accident -- the feature is incredibly niche, can be easily worked around by factoring the common code into a const, and only works in a very limited set of syntactic contexts.)

@pietroalbini
Copy link
Member

There's no point in cratering this.

@craterbot abort

@craterbot
Copy link
Collaborator

🗑️ Experiment pr-61723 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 11, 2019
@RalfJung RalfJung closed this Jun 11, 2019
@oli-obk oli-obk mentioned this pull request Jul 24, 2019
Merged
@RalfJung RalfJung deleted the no-more-recursive-enums branch July 6, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RalfJung @rust-highfive @bors @estebank @craterbot @oli-obk @pietroalbini