-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fn_call_style has no "Compressed" variant #2010
Comments
Should probably just skip calls like this. |
@nrc is this fixed, or should I just not write this method in the first? we are using |
You should use a skip attribute on a call like this.I think it is unlikely that rustfmt ever will (or even could) format a call like this nicely. |
This is what I ended up doing (skiping these calls). This issue was filled because I thought that adding a |
The trouble is that for most function calls, compressed is a pretty bad formatting style and we have no way of forcing an option on for some calls. We'd need to be 'smart' about when to apply different styles and people generally don't like these kind of 'heuristic' changes. |
I personally like to maximize use of vertical space so compressing function arguments is not that bad. I agree that it doesn't look very nice, but nice-looking code is not what I expect from an automatic formatting tool, the only thing I expect is that the resulting code doesn't need to be horrible. I am willing to live with overall worse looking code if that saves me having to write a lot of The |
Check this out. Before:
After
The text was updated successfully, but these errors were encountered: