Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format_macro_matchers deletes comments #3960

Open
AaronKutch opened this issue Dec 10, 2019 · 1 comment
Open

format_macro_matchers deletes comments #3960

AaronKutch opened this issue Dec 10, 2019 · 1 comment
Labels
a-macros bug Panic, non-idempotency, invalid code, etc. only-with-option requires a non-default option value to reproduce p-low

Comments

@AaronKutch
Copy link

When I just have a .rustfmt.toml with:

unstable_features = true
format_macro_matchers = true

Rustfmt 1.4.9 will the delete the comment in this:

macro_rules! m {
    (
        $arg0:ident, // comment
    ) => {};
}
@topecongiro topecongiro added a-macros bug Panic, non-idempotency, invalid code, etc. only-with-option requires a non-default option value to reproduce labels Dec 11, 2019
@ytmimi
Copy link
Contributor

ytmimi commented Jul 21, 2022

Confirming I can still reproduce this using rustfmt 1.5.1-nightly (f2c31ba0 2022-07-19)

Linking the tracking issue for format_macro_matchers #3354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-macros bug Panic, non-idempotency, invalid code, etc. only-with-option requires a non-default option value to reproduce p-low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@topecongiro @ytmimi @AaronKutch