Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup target list output needs an alternative to color #1308

Closed
mqudsi opened this issue Dec 9, 2017 · 6 comments
Closed

rustup target list output needs an alternative to color #1308

mqudsi opened this issue Dec 9, 2017 · 6 comments

Comments

@mqudsi
Copy link

mqudsi commented Dec 9, 2017

Due to presumably the same bug as rust-lang/rust#45728, rustup does not emit color under a correctly-configured tmux (though it will if tmux is misconfigured, as most are), but that's not the issue I'm reporting.

The problem is that the output of rustup target list relies on color to distinguish between installed and uninstalled targets. If color is omitted, the only information discernable from the output is which target is installed and the default, other targets that are installed are displayed the same as targets that aren't.

@amar-laksh
Copy link

Output without colour (gnome-terminal):
screenshot from 2018-01-02 10-56-32

xterm:
screenshot from 2018-01-02 11-00-39

I think this is easy enough to distinguish especially with the default and installed rendered in bold text.

@mqudsi
Copy link
Author

mqudsi commented Jan 2, 2018

That just substitutes one meta property of the text for another. Not all terminals have bold support, copying and pasting loses that bold, etc.

@amar-laksh
Copy link

amar-laksh commented Jan 2, 2018

Yeah but again what can we do? Any suggestions? BTW even the linux ttys support bold text.

@mqudsi
Copy link
Author

mqudsi commented Jan 2, 2018

Installed:
  * abc (default)
  * def
Available:
  * foo
  * bar

@mqudsi
Copy link
Author

mqudsi commented Jan 2, 2018

Note that this has already been improved. There was no (installed) at the time I filed this bug.

@amar-laksh
Copy link

You should probably close the issue then.

@Diggsey Diggsey closed this as completed May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants