Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picking a default windows toolchain by detecting msvc is unpredectable #561

Closed
brson opened this issue Jul 5, 2016 · 3 comments
Closed

Comments

@brson
Copy link
Contributor

brson commented Jul 5, 2016

On Windows, rustup will detect whether MSVC exists, and if so will install the MSVC toolchain, otherwise GNU. That you get different software based on what happens to be preinstalled in your environment is unpredictable. As an alternative, we might instead do the detection, but always install the msvc toolchain, printing a warning with further instructions if you don't have MSVC.

cc rust-lang/prev.rust-lang.org#341 (comment) @Diggsey @vadimcn

@retep998
Copy link
Member

retep998 commented Jul 5, 2016

We could also ask the user what they want to do.

@brson
Copy link
Contributor Author

brson commented Jul 5, 2016

@retep998 The installer already surfaces an option to change the toolchain. It's fairly prominent, but it's not a direct question.

@Diggsey
Copy link
Contributor

Diggsey commented May 4, 2017

I think we always default to msvc now.

@Diggsey Diggsey closed this as completed May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants