Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo's test suite no longer works correctly #893

Open
brson opened this issue Dec 30, 2016 · 1 comment
Open

Cargo's test suite no longer works correctly #893

brson opened this issue Dec 30, 2016 · 1 comment

Comments

@brson
Copy link
Contributor

brson commented Dec 30, 2016

Dynamic linking issues around PATH of course: rust-lang/cargo#3394

@retep998
Copy link
Member

retep998 commented Feb 2, 2017

Rustup no longer adds the toolchain's bin folder to the path when running the toolchain binaries. Plugins dynamically link the standard library and as a result must be able to find the dlls from the toolchain's bin folder. When running tests on a plugin, the plugin test binary still depends on those dlls, but is running standalone, and because the dlls are no longer in PATH, the test binary fails to find the dlls and crashes.

This is a pretty major blocker for anyone trying to test plugins. Rocket is one such project affected by this. This also prevents anyone from using -Cprefer-dynamic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants